On Wed, Dec 2, 2009 at 01:18, Steve Borho <st...@borho.org> wrote:
> On Tue, Dec 1, 2009 at 3:18 AM, Adrian Buehlmann <adr...@cadifra.com> wrote:
>> On 01.12.2009 04:52, Yuki KODAMA wrote:
>>> On Sat, Nov 28, 2009 at 00:57, Adrian Buehlmann <adr...@cadifra.com> wrote:
>>>> # HG changeset patch
>>>> # User Adrian Buehlmann <adr...@cadifra.com>
>>>> # Date 1259336753 -3600
>>>> # Node ID 774bd409298c6d18e9a1f177ae7a8b6dbd4c1789
>>>> # Parent  741eceb05c9eb14f79799edc083abee25e156d32
>>>> logview: draw a thicker line to second parent
>>>>
>>>> Allows to identify the second parent in the graph.
>>>>
>>>> Always highlight the second parent in the changeset info
>>>> for consistency with the highlighting in the graph.
>>>>
>>>> The compact graph mode is not affected.
>>>
>>> Sigh, this changeset causes #769
>>> http://bitbucket.org/tortoisehg/stable/issue/769/
>>> Adrian, if you really think about consistency, you may want to fix
>>> graph drawing, not csinfo highlight.
>>> If you're not going to fix graph drawing, I hope backing out this changeset.
>>>
>>
>> I'm fine with backing this out.
>
> Was it just the change to changeset.py that broke csinfo?  I could
> backout just that change.
>
> --
> Steve Borho
>

Yes, the line is line 496 in changeset.py:
496                    highlight = len(pctxs) == 2 and pctx == pctxs[1]

Highlighting current diff parent is nice idea,
so I'll try to improve the method of graph drawing later.

-- 
Yuki KODAMA

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
Tortoisehg-develop mailing list
Tortoisehg-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop

Reply via email to