On Fri, 22 Nov 2013 10:18:28 +0100, Simon Heimberg wrote: > # HG changeset patch > # User Simon Heimberg <sim...@besonet.ch> > # Date 1384204372 -3600 > # Node ID 2cd51a22e5d35ba3199288eade014390fb34a276 > # Parent 6196dddb51b87dbfd1b1213ed05a59a6b52623ba > graph: only draw one line to one parent > > Because the parents originate from multiple soucres it is theoretically > possible > that several point to the same revision. Only take the first of this (which is > graftsource because it is added before). > > diff -r 6196dddb51b8 -r 2cd51a22e5d3 tortoisehg/hgqt/graph.py > --- a/tortoisehg/hgqt/graph.py Die Nov 05 19:11:38 2013 +0100 > +++ b/tortoisehg/hgqt/graph.py Mon Nov 11 22:12:52 2013 +0100 > @@ -154,6 +154,8 @@ > preferred_color = curcolor > for parent, link_type in parents: > if parent not in next_revs: > + if parent in parents_to_add: > + continue
It looks good to me, but please insert a brief comment describing the problem solved by this change. Is this happen if both "graft source" and "obsolete precursor" point to the same revision? The other patches also look good. Regards, ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk _______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
