On Tue, Feb 3, 2009 at 11:32 PM, Steve Borho <[email protected]> wrote: > On Mon, 2009-02-02 at 22:20 -0800, Peter Ruibal wrote: >> So, If i make a minimal amount of changes to my working copy of the >> repo, I see the behavior I described at length (and apparently, you >> had already implemented!) -- synchronicity between the two treeviews . >> >> But -- As soon as I start applying more extensive changes, however, it >> stops working consistently for me. >> >> I've been able to reproduce it on your thg repository itself: >> >> After doing: > > I'm stepping through these myself so I can see what you see. > >> hg import --no-commit >> http://bitbucket.org/fmoo/thg-win32-setup-etc/raw/cd4234049254/setup-hgtk-driver.patch >> hgtk commit >> >> Clicking on either of the changes to shlib.py does not cause the >> corresponding treeview row on the file picker to be marked >> deselected / inconsistent, > > Single clicking, or just selecting hunks in the diff view doesn't toggle > them, they must be dbl-clicked or 'activated' in the GTK sense. > Hitting [space] or [enter] on a selected hunk will activate it. I > suspect you already know this based on your comments below, but wanted > to be clear. > > When I do this on one of the shlib.py diff hunks, the file's toggle > switches to the inconsistent state for me. If I 'activate' the diff > header for shlib.py, it toggles both hunk states. > >> So then if I close and re-open the dialog (just to get it to a known >> state): >> 1) de-select setup.py from the file treeview >> 2) double-click the first chunk from shutil.py >> 3) check 'show rejected chunks' >> >> All of the chunks and descriptions disappear. >> >> 4) uncheck 'show rejected chunks' >> >> The second chunk from shutil.py and setup.py diff header reappear, >> both with strikethrough >> >> If you're unable to reproduce this, I'll start digging into this >> myself. > > I don't get this myself. Can you tell me the platform you're testing > on; the O/S, Gtk, PyGtk, and python versions? This has received very > little testing on Windows so far, so there may be issues on that > platform that need to be worked through.
Nice. I can verify the things you see on Windows. The 'inconsistent' state is completely ignored by the toggle widget, and the diff hunk tree does get confused when you toggle 'show rejected patches'. Both of these are GTK problems that I'll need to find a way to work around. Thanks for the heads up. -- Steve ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ Tortoisehg-discuss mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-discuss
