On Sun, Sep 13, 2009 at 1:59 AM, Adrian Buehlmann <[email protected]> wrote: > On 13.09.2009 01:45, Steve Borho wrote: >> I've been trying to get rid of the toolbar dropdown menus since they >> seem to confuse users pretty regularly. There are two left, both in >> history.py, and I could use some feedback on how to replace them. > > Hmm. Never seen that. The black triangle is a pretty well known > ui idiom. Even on Windows, quite a couple of Applications use it in > toolbars (but see below). > > If you want to remove them though, I won't stand in your way. > Specifically, adding a "Navigate" menu (see below) would be fine > by me. > > While we are at it: IIRC in the Windows user interface guidelines, > the gold standard is that toolbar buttons are just shortcuts > for menu items. No feature should be available via toolbar > buttons exclusively. Toolbars should be hideable and the application > should then still be usable. But I won't insist on that > for TortoiseHg :). I'm just taking the opportunity to mention it here.
Qt actually requires this to be true. To create a toolbar button you must create a menu event first. We can make this a goal of 0.9, for the two apps that have menu bars. Just need to come up with a name for the toolbars in the commit tool that operate on checked files. > Another benefit I see in removing the dropdowns in toolbar buttons is that > it conserves space. The GTK drop down angles make the toolbar buttons > overly wide (for my taste). > >> * the drop down on the 'Select Revision' button. Currently just has >> 'tip', 'parent' >> >> My thought is to add a menu named 'Revision'. The first entry would >> be 'Select Revision...' and it would open the dialog. Below that >> would be a divider then tip, parent, and maybe the most recent 10 >> tags. Leave the toolbar button for easy access, but remove it's drop >> down menu. > > That's fine by me. > > Maybe do the menu content like this? > > Navigate <- name of menu > ---- > Tip > Parent 1 > Parent 2 <- disable that, if there is only one (grey it out) > ---- > Revision... <- opens goto dialog > ---- > default <- put branch names in this group (not tags). > "default" on top, > don't show this group if there is just the default > branch > stable > feature1 > release7 > ... <- limit number of entries to 20 > More branches... <- and put this entry if there are more, > to open a dialog to select > > (we could leave away implementing the "More branches..." thing > in the initial version for this menu) > > I would be fine with removing the "Select Revision" button from the > toolbar. The text eats up too much space anyway and I would like > to conserve space for the sync buttons that will be added later > (sync dialog integration into history). Yeah, that looks like a good plan. > Datamine button could go as well, since we have the tools menu now. Sure. > My original idea when I added the Select Revision dialog was to have the > input field in a toolbar instead (a navigation/address bar?), but then you > added the filterbar and I couldn't find a good place to put this > input field. > >> * Yuki's patch that adds a 'Refresh Completely' menu option to the >> refresh button. >> >> The whole purpose of this button is to reset the origtip variable so >> changesets pulled or committed after the dialog was launched no longer >> show up green. I'm having a hard time coming up with a good place for >> it. > > I haven't tried that, so no response here. > We'll need a menu for the refresh option to satisfy the toolbar requirement, so we might as well give it two options. I see in Firefox reload is under the View menu, and our tooltip for the refresh toolbar button actually reads 'reload revision history'. So the view menu seems the best place for it. I can't decide on a good name for it. 'Reload Completely' seems too vague. 'Reset tip'? 'Forget tip'? dunno. -- Steve Borho ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Tortoisehg-discuss mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-discuss
