Yuki's change

http://bitbucket.org/tortoisehg/stable/changeset/8cc8eed22f46/

in the default branch (for 0.10) to the update dialog doesn't look good:

http://bitbucket.org/abuehl/thg-abuehl/downloads/8cc8eed22f46.png
http://bitbucket.org/abuehl/thg-abuehl/downloads/8cc8eed22f46-expanded.png

having a checkbox in the label of an expander is bad.

Introducing yet another ui wart just to hide two options in the
update dialog is the wrong way to go, IMHO.

For reference, the update dialog before that change looks like
this:

http://bitbucket.org/abuehl/thg-abuehl/downloads/before-8cc8eed22f46.png

And yes, the --clean option checkbox must always be visible, because of its
drastic effect (as I already mentioned in the past a couple of times).

Side note 1:

The change message

"update: move options into the expander"

is grossly misleading, as the change *introduces* an expander, so it would have
been better to say so. The change does not move options into "the" expander
-- as there was no expander before.

Side note 2:

8cc8eed22f46 moves the --clean checkbox to below the "Target" label. I'm ok
with that, but I would have appreciated if it would have been done in a
separate first change or at least would have been mentioned in the change
message of 8cc8eed22f46.

(The original idea of having it more towards the top was because of the
drastic consequences of enabling --clean.)





------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Tortoisehg-discuss mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tortoisehg-discuss

Reply via email to