On Sat, Jan 2, 2010 at 4:01 PM, Adrian Buehlmann <[email protected]> wrote: > (taking this off the mercurial list) > > On 02.01.2010 19:20, Steve Borho wrote: >> On Sat, Jan 2, 2010 at 12:16 PM, Adrian Buehlmann <[email protected]> wrote: >>> On 02.01.2010 18:10, Steve Borho wrote: >>>> On Sat, Jan 2, 2010 at 6:17 AM, Adrian Buehlmann <[email protected]> >>>> wrote: >>>>> On 02.01.2010 03:41, Steve Borho wrote: >>>>>> TortoiseHg 0.9.2 is a bug fix release. >>>>>> >>>>>> http://bitbucket.org/tortoisehg/stable/wiki/ReleaseNotes >>>>>> >>>>>> http://bitbucket.org/tortoisehg/stable/downloads/tortoisehg-0.9.2-hg-1.4.2.exe >>>>>> >>>>> >>>>> Probably will need a 0.9.2.1: >>>>> >>>>> http://bitbucket.org/tortoisehg/stable/issue/839/092-installer-doesnt-call-tortoiseoverlays >>>> >>>> Thanks for catching this Adrian. I've uploaded a new installer: >>>> >>>> http://bitbucket.org/tortoisehg/stable/downloads/tortoisehg-0.9.2-1-hg-1.4.2.exe >>>> >>>> If you link to our packages, please update your URLs. Thanks. >>>> >>> >>> I assume this was built using 275690997c5f, which is currently untagged. >>> >>> Last time you appended '.1', now it is '-1' and without tagging. >> >> Last time, I changed code that affected the tarball so a new tag was >> necessary. This time around, it just needed an ISS change so I just >> rebuilt the installer. > > Sure. But you changed code here as well. Code that is executed at > install time on windows. > > The delivery item for Windows is an exe that installs TortoiseHg. > > Treating this case here (changing installer code) special by not following > preexisting release patterns (build release and tag it) doesn't make that > much sense IMHO. > > The .iss source that was changed for this special '-1' "release" is > even in the same repository as the sources for the hgtk dialogs of > TortoiseHg. > > In the past we could update the main TortoiseHg repo to a tag (e.g. 0.8) and > we > got the versions of the .iss sources that were used to build that exact > release > (because the .iss sources are part of the main TortoiseHg repo). > > This deviation in release process at least breaks that invariant. > > Consider a fictitious dialog among developers in some distant future: > > "Oh, 0.9.2-1 was special, I remember we fixed the .iss files after > 0.9.2 for that but we didn't tag it" -- "Oh, and what versions of the > iss files were taken for that?" -- "Not sure, probably that change in the > stable branch directly after the tagging cset for 0.9.2, but I can't tell > for sure anymore". > > Not exactly the way we are supposed to use Mercurial, isn't it?
This is a gray area, but this is how I look at it. If I make a new tag, I have to make a new tarball so all the other packagers out there can build their packages for their operating systems. A 0.9.2.1 tarball would be identical to an 0.9.2 tarball, except for the version number. This seems very counter-productive. We also keep the RPM .spec file in the repository. If the RPM packager finds a bug in the .spec file after a release, we do not expect to have to retag the release just to fix the .spec file. I would expect them to fix the .spec file, make an 0.9.2 rpm file, and send a fix for inclusion in the stable branch. The -N postfix on version numbers is a pretty common convention for 'package respins of a single code release', which is what this was. I think someone looking back at this two years from now could pretty quickly figure out why an 0.9.2-1 package was made, and which version of the ISS file was used. If you don't agree with that, the best course of action would be to make a commit to thg-winbuild that knows how to regenerate 0.9.2-1 (check out 0.9.2, then get the ISS file from the very next changeset). Then we could tag that thg-winbuild changeset with 0.9.2-1. -- Steve Borho ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Tortoisehg-discuss mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-discuss
