On Sun, May 9, 2010 at 4:41 PM, Sherief N. Farouk <[email protected]> wrote: > Hi guys, > > > > I’ve been using THG 0.8.x on my main development machine for > a while (no complaints, so didn’t bother upgrading. I know, I know), and I > recently got a new machine to test drive a new development setup – I > installed THG 1.x on that, which went smoothly. However, the new commit UI > struck me as a step backwards: usually, I like how the old UI gives you a > hunk selection interface, that way I can make a bunch of changes, then > commit them in N commits where each commit is a LOGICAL unit, encompassing a > single change to the codebase. This helps us mix and match builds for any > client’s needs, which works WONDERFULLY with Hg. The new commit UI, however, > has three tabbed views in the lower right, and it defaults to text diff > (which is not very useful IMO, but I think that’ mainly due to the way *I* > use THG). But looking across all three views, they seem to be extremely > redundant (again, this might be a misinformed decision, bear with my > argument though). First of all, “Text Diff” and “Commit Preview” come up > with EXACTLY the same output – can someone point out a case where the output > would be different?
If you ever have more than one file to commit, they will be different. Commit preview shows the result of all file/chunk selections; the full commit. > Second, the difference between “Text Diff” and “Hunk > Selection” is that Hunk Selection removes the files changed part (--- > a/foo.c ), and replaces it with a summary – which is legit, but I think the > Text Diff view (if that’s it’s only difference from Hunk Selection) is just > a bit of bloat: the changed files are already displayed in the lower left, > so why display them again? What was the rationale for moving to this new UI? > I looked up the repo but couldn’t find anything significant in status.py’s > history – if I happened to miss it, please point me to it. The hunk selection pane does not allow text selection for copy/paste, and it cannot show diffs for copied/renamed files, nor does it show diffs for added or removed files. > While I’m all for adding features, I believe that this > change does more harm than good, in terms of UI bloat. It’s tricky, and I > know you might hate me for this next sentence, but I believe UIs should be > dealt with in a more mac-like approach and less common-FOSS-program approach > (Disclaimer: I don’t own Macs, never used them for development, but the > screenshots for their Hg UIs look pretty). I hate the fact that an extra > click has been added to EVERY single commit I make, for no reasonable return > in utility. You do change selection in every commit? It would be trivial to make the chunk tab the default, but for many users this would be a step backwards. > Like I said before, I might be wrong, and if I’m missing some > common usage scenarios where the 3 view modes would be helpful I’d love to > hear about them. I somewhat agree, and the new Qt based commit tool will not have any tabs. That said, the chunk selection feature will still not be the default interface, because it is only useful for M status files. The default view will always show working directory diffs. The current plan is for chunk selection to be a popup dialog, allowing chunks to be reverted, moved to a patch, or simply held from the commit. -- Steve Borho ------------------------------------------------------------------------------ _______________________________________________ Tortoisehg-discuss mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-discuss
