On 15 December 2010 16:48, Steve Borho <[email protected]> wrote:
> On Wed, Dec 15, 2010 at 9:27 AM, André Sintzoff
> <[email protected]> wrote:
> > 2010/12/15 Steve Borho <[email protected]>:
> >> On Wed, Dec 15, 2010 at 2:14 AM, André Sintzoff
> >> <[email protected]> wrote:
> >>> 2010/12/15 Steve Borho <[email protected]>:
> >>>> The filter bar is now opened with CTRL+S and hidden with ESC or the
> >>>> close button. It needs a menu item as well, so it is discoverable.
> >>>
> >>> Is there any sense to align this with the Output Log?
> >>> For the Output Log, Ctrl+L is a toggle (same keys to open and to hide).
> >>> I would prefer to have also a toggle for the Filter bar.
> >>> What do you think?
> >>
> >> This is how the other pop-up toolbars work. CTRL+F or CTRL+SHIFT+G to
> >> show, ESC or close button to hide.
> >
> > When several pop-up toolbars are displayed, the ESC key has no effect.
> > Therefore, it is not possible to hide a pop-up toolbar with a
> > keystroke if an other one is also visible.
>
> I wouldn't object to a changeset that added three actions to the
> Workbench view menu that provided 'Toggle Revset/Filter Bar CTRL+S',
> 'Toggle Find Bar CTRL+F', 'Toggle Goto Bar CTRL+SHIFT+G'.
I'm trying to implment this, but I cannot come up with a nice solution for
moving the shortcuts to the workbench menu.
Ctrl+S = repowideget.toggleact on repowidget.filterbar = RepoFilterBar
Ctrl+Shift+G = quickbar.GotoQuickBar used in repowidget.py
Ctrl+F = qscilib.SearchToolBar used in qscilib.py
The first two widgets are based on QToolBar and all add an 'Open' action to
"their parent", which looks strange to me. I guess this is to enable the
shortcut. As far as I can tell this means that every instance of a
repowidget has an action with the same shortcut. For the FindQuickBar it is
not the repowidget, but some child widget. It works apparently - the
shortcut is only enabled when it makes sense.
But how do I connect one action in my workbench menu with 0..N actions on
child widgets? Should I define a custom event? The approach used by
updateTaskViewMenu is another possibility, but it it require knowledge of
the internals of the child widgets and their hierarchy. Any recommendations?
It seems that the shortcut (e.g. Ctrl+S) should be on the workbench menu
action to be seen, but this interferes with the toolbar action that also
defines the shortcut. I guess I would disable the shortcut on the toolbar,
but then I'm lacking the mechanism for enabling and disabling the action as
the widgets are shown and hidden.
Regards,
Peer
------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
Tortoisehg-discuss mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tortoisehg-discuss
