On Tue, 19 Nov 2013 13:06:20 +0200, Stanimir Stamenkov wrote:
> Tue, 19 Nov 2013 10:20:24 +0200, /Stanimir Stamenkov/:
> > Tue, 19 Nov 2013 02:09:18 -0600, /Steve Borho/:
> >> On Nov 19, 2013, at 1:59 AM, Stanimir Stamenkov wrote:
> >>> Tue, 19 Nov 2013 01:49:58 -0600, /Steve Borho/:
> >>>
> >>>> You're problem almost certain isn't with the TortoiseHg release,
> >>>> it is almost certainly caused by the new Mercurial release which
> >>>> happened to coincide with it.  That extension is apparently not
> >>>> quite ready for Mercurial 2.8 yet.
> >>>
> >>> O.k.  I'll address this to the extension author, but it is
> >>> interesting to note committing from the command line appears to
> >>> work fine.
> >>
> >> That is indeed an interesting note.  A full traceback would be 
> >> helpful.
> > 
> > Do you know how I could get to it?  I'm observing just a modal 
> > "Commit" message box with the given message:
> > 
> > "
> > abort: could not lock repository \\?\C:\tmp\repo: Invalid argument

It seems win32lfn fails to normalize directory separator.

In Mercurial, os.open("\\\\?\\C:\\tmp\\repo\\.hg\\store\\lock", ...) was called,
but it was os.open("\\\\?\\C:\\tmp\\repo\\.hg/store/lock", ...) in TortoiseHg.

> Trying it with --debug --traceback from the "Output Log" view:
> 
> % hg commit --verbose --debug --traceback --user stanio --message=test -- 
> "C:\tmp\repo\bar"
> abort: could not lock repository \\?\C:\tmp\repo: Invalid argument
> [command returned code 255 Tue Nov 19 13:01:10 2013]
> 
> (still the same)
> 
> The same from the Windows command prompt succeeds:
> 
> C:\tmp\repo>hg commit --verbose --debug --traceback --user stanio 
> --message=test -- "C:\tmp\repo\bar"
> bar
> committed changeset 1:c22d80373333171d2b807c18c23d1283820a9820

I guess this difference comes from the win32lfn's chdir wrapper.

The command-line hg calls os.chdir() before loading extensions, but in
TortoiseHg, chdir is called after.

Regards,

------------------------------------------------------------------------------
Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing 
conversations that shape the rapidly evolving mobile landscape. Sign up now. 
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________
Tortoisehg-discuss mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tortoisehg-discuss

Reply via email to