On Thu, 18 Sep 2014 00:32:27 +0300, Stanimir Stamenkov wrote:
> Thu, 18 Sep 2014 01:06:15 +0900, Yuya Nishihara wrote:
> > For the width, it was changed by 363608abee0c to save space and there were
> > no complaints. I think it will be okay to make the width 1.2-1.5x wider
> > if many people love it.
> >
> > https://bitbucket.org/tortoisehg/thg/commits/363608abee0c
>
> I'm generally peeking at the thg-dev list and I've seen when it has
> been introduced. I didn't like it initially, I still don't like it,
> but I didn't complain earlier as wanted to give it time to see if I
> wouldn't change my mind. Then I've given it a try and experimented
> hacking the source to bring the wider graph back, and I've been
> generally satisfied with the result. Still I see the relevant
> sources get refactored quite a bit lately, and I would love to see
> at least a configuration option (scaling factor which could be
> manually added, no need of a GUI) to control this presentational detail.
Personally I don't want to increase the number of paranoid options.
I'm fine to change the ratio up to 1.5x. I think 1.25x is good.
--- a/tortoisehg/hgqt/repoview.py
+++ b/tortoisehg/hgqt/repoview.py
@@ -444,7 +444,7 @@ class GraphDelegate(QStyledItemDelegate)
self._rowheight = 16 # updated to the actual height on paint()
def _col2x(self, col):
- maxradius = max(self._rowheight / 2, 1)
+ maxradius = int(max(self._rowheight / 2, 1) * 1.25) # XXX hack
return maxradius * (col + 1)
def _colcount(self, width):
These days, few people respond to a patch even though it is RFC including
important look-and-feel change.
Regards,
------------------------------------------------------------------------------
Slashdot TV. Video for Nerds. Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
_______________________________________________
Tortoisehg-discuss mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tortoisehg-discuss
