A Popover is closed automatically if you click outside of it. Esc and
outside click is basically the same thing. In any other circumstances it
is the developer who closes it, for instance when an action is selected.
So there shouldn't be any difference between handling Esc or outside
click. Any other closing case can be captured by the actions assigned to
close the Popover.

I see the Browser's bookmarking popover has a Cancel action on the
bottom. This is pretty confusing as Popovers are not Dialogs, which
would need an explicit action on their layout to be able to close - Esc
or outside click does the job.

But really, what si the use case you need to know the Popover was
dismissed?

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in
Ubuntu.
https://bugs.launchpad.net/bugs/1546677

Title:
  Popovers doesn’t allow overriding onEscapePressed

Status in ubuntu-ui-toolkit package in Ubuntu:
  New

Bug description:
  With the fix for bug #1523828, popovers are automatically closed when
  ESC is pressed. This is a good default behaviour, however the
  implementation is unfortunate: because the escapePressed handler is
  defined on the foreground (a child item of the root popover), app
  developers don’t get a chance to override it.

  Here’s a concrete use case: in the browser, when bookmarking a page
  with Ctrl+D, a popover with bookmark options is shown. We want the
  Enter key to validate the options and save the bookmark, and the ESC
  key to remove the bookmark.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1546677/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to     : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to