Hi Tim, I don't think that this behavioural change is related to the bugs fixed by that MP. I believe that those bugs can be fixed, while retaining the old (and documented) behaviour of setting the flickable margin to the height of the header. All what those bugs say, is about the margin behaviour when then flickable is *not* bound to the header (or is bound to an invisible header); but in fact, in fixing those bugs you also changed the behaviour of the flickable margin when it's attached to a visible header. I think that this part of the change could and should be left out.
Do we actually have any bugs filed by developers complaining that the flickable's topMargin is being overwritten when the flickable is attached to a header? If we don't let's not fix it. Besides, it's documented to behave like that, so I really see no point in changing it now. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in Ubuntu. https://bugs.launchpad.net/bugs/1572525 Title: [regression] Double header height is set as flickable topMargin Status in Canonical System Image: Incomplete Status in ubuntu-ui-toolkit package in Ubuntu: In Progress Bug description: Th attached test application works fine under qml-module-ubuntu- components 1.3.1918+16.04.20160404-0ubuntu3 but breaks with the latest 1.3.1938+16.04.20160416. At a first examination, I believe that the change which cause the regression is this one: https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/invisible- header-topmargin/+merge/290659 Run the attached test case with QML scene. You can scroll the view horizontally to see the other model items. Under the old version of the toolkit, all items have their page headers correctly aligned; with the new version, an extra spacing is added below the header. I found this bug while testing my ttrss app in rc-proposed; please don't let this UITK version reach our users, as more apps might be affected. To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1572525/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
