"Therefore if there are several actions in the leading action slot, all will be disabled. Can we change the API so that there is flexibility when choosing one action to be disabled rather than all of them?"
That is not true. Beware that the disabled state is not for the background mainly, but for the text color. And the icon color is enabled sensible, meaning it uses different colors for enabled or disabled state. As we discussed once with Rae, there are some possibilities for coloring: [16:20:12] <raeshambrook> hi zsombor quick question, what colour are we currently using for the background of leading and trailing actions? [17:27:56] <zsombi> oh, sorry, I did not seen your ping' [17:28:48] <zsombi> it is normal.foreground [17:32:04] <raeshambrook> can we have different variations of it? basically what we want to do now is have a set to choose from depending on how severe the action is. e.g. red for delete, foreground for dismiss or hide [17:32:52] <zsombi> well, the icon color is red now for delete, the background is different [17:33:50] <zsombi> if you want to do that per action, the list panels will look like clothes from '60s [17:35:46] <raeshambrook> well we were wanting to change it back to red background and white icon but only for actions like delete. we have some other instances, like “dismiss” in notifications and “remove” in group chat where we want to use foreground (light and dark) and .foreground text [17:36:31] <raeshambrook> when these instances are in red, they look way too severe. like in group chat, removing someone from a chat group looks like you are removing them from your address book [17:36:36] <zsombi> but if you combine those with other actions, they will have different backgrounds... it may be what you want though... [17:36:56] <raeshambrook> you mean if we had two leading actions for instance? [17:37:15] <zsombi> yes [17:37:39] <zsombi> I know we advice not to, but if apps put sthing else, they'll have it in pepita [17:38:49] <raeshambrook> well our recommendation is to use leading actions for destructive and trailing for positive/neutral . if they break this, then yes, could look a but weird. but that’s why it would be great to have options to choose from. if not red, then a more neutral look like .foreground and .foregorund text [17:39:22] <raeshambrook> is there a way to have a variation like this? [17:39:28] <zsombi> ok... well, we can change the panel color into red, np, like I can use negative there [17:40:05] <zsombi> otoh, we don't have the ability to colorize the action colors individually, for that a custom delegate (painter) must be declared [17:40:23] <raeshambrook> right, we would want it back to red for things like delete. but not for every leading action….what do you mean? [17:40:44] <zsombi> well, that is something we cannot drive automatically [17:40:53] <zsombi> that's what I meant [17:41:09] <zsombi> we don't know whether an action is negative or not [17:42:16] <raeshambrook> so if someone wanted it changed, they’d have to do it themselves, can it be overridden in the SDK? or do they have to build the whole component from scratch? [17:42:25] <zsombi> yes [17:42:35] <zsombi> they have to color it themselves [17:42:41] <zsombi> that's th edelegate [17:42:55] <raeshambrook> but can still use the SDK component though [17:42:56] <zsombi> the delegate paints/views the action [17:42:59] <zsombi> yes [17:43:17] <raeshambrook> so it’s just a matter of us deciding to make the default neutral or red [17:43:23] <zsombi> yep [17:43:46] <raeshambrook> i’ll will talk to the others about it [17:43:52] <raeshambrook> thanks for the info [17:43:55] <zsombi> yw -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in Ubuntu. https://bugs.launchpad.net/bugs/1603452 Title: [SDK] Change leading action background to red and icon to white Status in Ubuntu UI Toolkit: New Status in Ubuntu UX: New Status in ubuntu-ui-toolkit package in Ubuntu: New Bug description: We'd like to change the leading action background from light grey back to red. And switch the icon from red to white. However, I have spoken to Andrea and the problem is regarding when a leading action is disabled. Outlined as follows: the default action delegate is just an Item { Icon {} } so it has no background, see: http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu- ui- toolkit/staging/view/2033/src/Ubuntu/Components/Themes/Ambiance/1.3/ListItemStyle.qml#L120 Moreover, the whole ListItemActions panel uses only one colour for the background http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui- toolkit/staging/view/2033/src/Ubuntu/Components/Themes/Ambiance/1.3/ListItemStyle.qml#L51 Therefore if there are several actions in the leading action slot, all will be disabled. Can we change the API so that there is flexibility when choosing one action to be disabled rather than all of them? To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1603452/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
