### VERIFICATION XENIAL ### * Couldn't reproduce the above situation using the proposed package version "3.8.7-2ubuntu2.16.04.2" using Xenial/16.04 LTS.
* Ran the testsuite against "3.8.7-2ubuntu2.16.04.2" and no errors were found, apart from a recurrent one which look to me like it did succeed but reported a failure. (false positive). (It has the exact same report result as previous version "3.8.7-2ubuntu2.16.04.1") == Testsuite Full Report -- # ./test setfacl failed on this system. ACL tests will not be executed. ./test: line 33: type: selinuxenabled: not found SELinux disabled. SELinux tests will not be executed. Running test 1 Running test 2 Running test 3 Running test 4 Running test 5 Running test 6 Skipping SELinux part of test 6 Running test 7 Running test 8 Running test 9 Running test 10 Skipping SELinux part of test 10 Running test 11 Running test 12 Running test 13 Running test 14 Running test 15 Running test 16 Running test 17 Running test 18 Running test 19 Running test 20 Running test 21 Running test 22 Running test 23 Running test 24 Running test 25 Running test 26 Running test 27 Running test 28 Running test 29 Running test 30 Running test 31 Skipping test 32: no ACL support Skipping test 33: no ACL support Running test 34 Skipping test 35: no ACL support Running test 36 Running test 37 Running test 38 Running test 39 Running test 40 Running test 41 Running test 42 Running test 43 Running test 44 Running test 45 Running test 46 Skipping SELinux part of test 6 Running test 47 Skipping SELinux test 47 Running test 48 Skipping test 48: no ACL support Running test 49 Running test 50 Running test 51 Running test 52 Running test 53 Running test 72 error: destination /tmp/logrotate-3.8.7/test/test.log.1.gz already exists, renaming to /tmp/logrotate-3.8.7/test/test.log.1.gz-2017081520.backup -- - Eric ** Tags removed: verification-needed-xenial ** Tags added: verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to logrotate in Ubuntu. https://bugs.launchpad.net/bugs/1709670 Title: logrotate never recovers if the statefile is corrupted Status in logrotate package in Ubuntu: Fix Released Status in logrotate source package in Trusty: Fix Committed Status in logrotate source package in Xenial: Fix Committed Status in logrotate source package in Zesty: Fix Committed Status in logrotate source package in Artful: Fix Released Status in logrotate package in Debian: New Bug description: [Impact] logrotate never recovers if the statefile is corrupted unless you remove it or fix the corruption by hand. Impact scenarios : - System could eventually run out of disk space on a separate partition if mounted in "/var" or specifically "/var/log" or even worst if "/var/log" is on the same partition as "/" it could create even more damage if by any chance the partition is running out of free space. - System keep updating the same files over and over, creating large size logfiles. - ... [Test Case] - Install logrotate - Run "/etc/cron.daily/logrotate" ## The first logrotate run will generate the statefile "var/lib/logrotate/status" - Modify "/var/lib/logrotate/status" by removing the first line in order to corrupt the file - Re-run "/etc/cron.daily/logrotate" and one will get the following error : "error: bad top line in state file /var/lib/logrotate/status" every time you run logrotate Unless you remove the statefile and start again or fix the corruption by hand. * Additionally, I will run the /path_to_source/test/test script as a dogfooding that does ~72 tests. [Regression Potential] * Risk of potential regression is low, and IMHO couldn't be worst than the actual situation where logrotate simply doesn't recover from a corrupt statefile. * The current patch does recover (after verification) and has been through some upstream CI validation, community feedbacks, et al. * Additionally, I will run the /path_to_source/test/test script as a dogfooding that does ~72 tests. [Other Info] * Upstream commit: https://github.com/logrotate/logrotate/commit/b9d82003002c98370e4131a7e43c76afcd23306a * Upstream bug: https://github.com/logrotate/logrotate/issues/45 * Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871592 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
