Uploaded in Trusty upload queue. It is now waiting on SRU verification team approval to start building in trusty-proposed.
# Sponsoring note [Nitpick] - Add (LP: #1771557) in debian/changelog [Note] * The sed command seems pretty solid. The "*" is indeed a good idea, even if IMHO unlikely to exceed 2 digits if it happen the cmd will match any number that precedes "n", "p" and the end, even if exceeding 2 digits. * I don't have an NVMe drive handy, but I know gpicolli did all the necessary validation pre-SRU. [Manual verification] Testing different nvme drive naming scenarios: $ echo "nvme1n2p3" | sed 's/\(nvme[0-9][0-9]*n[0-9][0-9]*\)p[0-9]*/\1/g' nvme1n2 $ echo "nvme11n22p33" | sed 's/\(nvme[0-9][0-9]*n[0-9][0-9]*\)p[0-9]*/\1/g' nvme11n22 $ echo "nvme11n22p33" | sed 's/\(nvme[0-9][0-9]*n[0-9][0-9]*\)p[0-9]*/\1/g' nvme11n22 $ echo "nvme111n222p333" | sed 's/\(nvme[0-9][0-9]*n[0-9][0-9]*\)p[0-9]*/\1/g' nvme111n222 $ echo "nvme1111n2222p3333" | sed 's/\(nvme[0-9][0-9]*n[0-9][0-9]*\)p[0-9]*/\1/g' nvme1111n2222 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to initramfs-tools in Ubuntu. https://bugs.launchpad.net/bugs/1771557 Title: NVMe boot drives not supported - failing in generating initramfs Status in initramfs-tools: Fix Released Status in initramfs-tools package in Ubuntu: Fix Released Status in initramfs-tools source package in Trusty: In Progress Status in initramfs-tools source package in Xenial: Fix Released Bug description: [Impact] When creating the initramfs image, mkinitramfs has multiple options on how to include modules. The default (and most common) one is the "MODULES=most", which includes the majority of filesystem modules and all the block device drivers. One other option is "MODULES=dep", which tries to descend in the sysfs hierarchy and guess modules to add, with the goal of reduce the size of initramfs. For the MODULES=dep case, the initramfs-tools hook-functions script cannot translate nvmeXnYpZ to nvmeXnY block device, so it's failing in the sysfs lookup, so it does not build the initram disk. Upstream solution is composed of at least 2 patches (it's a series, but the 2 below are really the needed ones): commit 3cb744c9 Author: Ben Hutchings <b...@decadent.org.uk> hook-functions: Rewrite block device sysfs lookup to be generic commit 8ac52dc0 Author: Ben Hutchings <b...@decadent.org.uk> hook-functions: Include modules for all components of a multi-disk device Instead of doing the huge backport, we added another sed substitution: currently the script has substitutions for sdX and hdX, in order to convert sda1 to sda, for example. The new substitution converts nvmeXnYpZ to nvmeXnY. It's less intrusive than the full backport, since this is a minimal SRU to Trusty only. [Test Case] 1. Install Trusty with rootfs in a multi-disk(md) array composed of two nvme partitions - in my tests, I've used a RAID1. (lsblk output of my test env: nvme0n1 259:0 0 10G 0 disk └─nvme0n1p1 259:1 0 10G 0 part └─md0 9:0 0 10G 0 raid1 / nvme1n1 259:2 0 10G 0 disk └─nvme1n1p1 259:3 0 10G 0 part └─md0 9:0 0 10G 0 raid1 / ) 2. Once system is booted, modify the "/etc/initramfs- tools/initramfs.conf", replacing "MODULES=most" to "MODULES=dep". 3. Update your initramfs by running something like: "update-initramfs -u -k <your kernel version>" The initramfs creating procedure will fail, unless the patch from this LP is present. [Regression Potential] If the sed expression was somewhat broken, we could have an issue generating initiramfs when MODULES is set to "dep", even for generic block devices (like regular HDDs). [Other Info] * This issue is based on Debian bug #785147: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=785147 * Only Trusty is affected, Xenial and late contains the full fix as mentioned above : $ git describe --contains 8ac52dc0 v0.121_rc1~11 $ git describe --contains 3cb744c9 v0.121_rc1~11 $ rmadison initramfs-tools initramfs-tools | 0.103ubuntu4 | trusty | source, all ==> initramfs-tools | 0.103ubuntu4.10 | trusty-updates | source, all initramfs-tools | 0.122ubuntu8 | xenial | source, all initramfs-tools | 0.122ubuntu8.11 | xenial-updates | source, all initramfs-tools | 0.125ubuntu12 | artful | source, all initramfs-tools | 0.125ubuntu12.1 | artful-updates | source, all initramfs-tools | 0.130ubuntu3 | bionic | source, all initramfs-tools | 0.130ubuntu6 | cosmic | source, all To manage notifications about this bug go to: https://bugs.launchpad.net/initramfs-tools/+bug/1771557/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
