> It might be easier to resolve this by considering this as "mkinitramfs
fails on ZFS root without /etc/fstab lines for the ZFS filesystems when
MODULES=dep is used".

Yes, that sounds like an accurate summary. I'm not sure I follow how
/etc/fstab is related, though. Looking briefly through mkinitramfs, I
don't see where that is being used.

> Could you perhaps see if you can remove kdump-tools from the equation
like this?

Good idea. Here is a more minimal way to reproduce the issue: with ZFS on root
 - set 'MODULES=dep' in '/etc/initramfs-tools/initramfs.conf'
 - run 'sudo update-initramfs -u'

Below is an updated patch, which finds and adds the module for each
device in the zfs pool containing the root filesystem. I've tested the
patch on Bionic and Cosmic with both zfs and ext4 root filesystems. Note
that I wasn't entirely sure if we need to handle the case where
'dev_node' is /dev/root. I'm not familiar with that setup, so I'm not
sure whether that could even apply when using zfs on root.

--- hook-functions      2018-07-10 22:19:18.489142772 +0000
+++ /usr/share/initramfs-tools/hook-functions   2018-07-10 22:06:43.969661842 
+0000
@@ -357,6 +357,21 @@
                return
        fi

+       if [ "${FSTYPE}" = "zfs" ]; then
+               manual_add_modules "${FSTYPE}"
+
+               # ZFS uses the name of a filesystem instead of a device. Find
+               # the devices that make up the pool containing the specified
+               # filesystem, and add the appropriate driver for each device.
+               local poolname="${dev_node%%/*}"
+               zpool list -vPL "$poolname" | while read dev ignored; do
+                       # Ignore non-leaf vdevs by skipping anything that 
doesn't
+                       # look like an absolute path
+                       echo "$dev" | grep -q '^/' && block_dev_mod_add "$dev"
+               done
+               return
+       fi
+
        if [ "$dir" = / ] && [ "${dev_node}" = "/dev/root" ] ; then
                if [ -b "${dev_node}" ]; then
                        # Match it to the canonical device name by UUID

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to initramfs-tools in Ubuntu.
https://bugs.launchpad.net/bugs/1661629

Title:
  upgrade of kernel fails with mkinitramfs: failed to determine device
  for /

Status in initramfs-tools package in Ubuntu:
  Confirmed

Bug description:
  When upgrading packages with "apt upgrade" on Ubuntu 16.04.1 LTS with
  root on ZFS I get this error:

  Setting up linux-image-4.4.0-59-generic (4.4.0-59.80) ...
  Running depmod.
  update-initramfs: deferring update (hook will be called later)
  Examining /etc/kernel/postinst.d.
  run-parts: executing /etc/kernel/postinst.d/apt-auto-removal 4.4.0-59-generic 
/boot/vmlinuz-4.4.0-59-generic
  run-parts: executing /etc/kernel/postinst.d/initramfs-tools 4.4.0-59-generic 
/boot/vmlinuz-4.4.0-59-generic
  update-initramfs: Generating /boot/initrd.img-4.4.0-59-generic
  run-parts: executing /etc/kernel/postinst.d/kdump-tools 4.4.0-59-generic 
/boot/vmlinuz-4.4.0-59-generic
  kdump-tools: Generating /var/lib/kdump/initrd.img-4.4.0-59-generic
  mkinitramfs: failed to determine device for /
  mkinitramfs: workaround is MODULES=most, check:
  grep -r MODULES /etc/initramfs-tools/

  Error please report bug on initramfs-tools
  Include the output of 'mount' and 'cat /proc/mounts'
  update-initramfs: failed for  with 1.
  run-parts: /etc/kernel/postinst.d/kdump-tools exited with return code 1
  Failed to process /etc/kernel/postinst.d at 
/var/lib/dpkg/info/linux-image-4.4.0-59-generic.postinst line 1052.
  dpkg: error processing package linux-image-4.4.0-59-generic (--configure):
   subprocess installed post-installation script returned error exit status 2

  version of initramfs-tools is 0.122ubuntu8.8

  
  Output of mount is:

  sysfs on /sys type sysfs (rw,nosuid,nodev,noexec,relatime)
  proc on /proc type proc (rw,nosuid,nodev,noexec,relatime)
  udev on /dev type devtmpfs 
(rw,nosuid,relatime,size=8066020k,nr_inodes=2016505,mode=755)
  devpts on /dev/pts type devpts 
(rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000)
  tmpfs on /run type tmpfs (rw,nosuid,noexec,relatime,size=1623576k,mode=755)
  rpool/ROOT/ubuntu on / type zfs (rw,relatime,xattr,noacl)
  securityfs on /sys/kernel/security type securityfs 
(rw,nosuid,nodev,noexec,relatime)
  tmpfs on /dev/shm type tmpfs (rw,nosuid,nodev)
  tmpfs on /run/lock type tmpfs (rw,nosuid,nodev,noexec,relatime,size=5120k)
  tmpfs on /sys/fs/cgroup type tmpfs (ro,nosuid,nodev,noexec,mode=755)
  cgroup on /sys/fs/cgroup/systemd type cgroup 
(rw,nosuid,nodev,noexec,relatime,xattr,release_agent=/lib/systemd/systemd-cgroups-agent,name=systemd)
  pstore on /sys/fs/pstore type pstore (rw,nosuid,nodev,noexec,relatime)
  cgroup on /sys/fs/cgroup/freezer type cgroup 
(rw,nosuid,nodev,noexec,relatime,freezer)
  cgroup on /sys/fs/cgroup/blkio type cgroup 
(rw,nosuid,nodev,noexec,relatime,blkio)
  cgroup on /sys/fs/cgroup/net_cls,net_prio type cgroup 
(rw,nosuid,nodev,noexec,relatime,net_cls,net_prio)
  cgroup on /sys/fs/cgroup/memory type cgroup 
(rw,nosuid,nodev,noexec,relatime,memory)
  cgroup on /sys/fs/cgroup/hugetlb type cgroup 
(rw,nosuid,nodev,noexec,relatime,hugetlb)
  cgroup on /sys/fs/cgroup/cpu,cpuacct type cgroup 
(rw,nosuid,nodev,noexec,relatime,cpu,cpuacct)
  cgroup on /sys/fs/cgroup/pids type cgroup 
(rw,nosuid,nodev,noexec,relatime,pids)
  cgroup on /sys/fs/cgroup/devices type cgroup 
(rw,nosuid,nodev,noexec,relatime,devices)
  cgroup on /sys/fs/cgroup/perf_event type cgroup 
(rw,nosuid,nodev,noexec,relatime,perf_event)
  cgroup on /sys/fs/cgroup/cpuset type cgroup 
(rw,nosuid,nodev,noexec,relatime,cpuset)
  mqueue on /dev/mqueue type mqueue (rw,relatime)
  hugetlbfs on /dev/hugepages type hugetlbfs (rw,relatime)
  systemd-1 on /proc/sys/fs/binfmt_misc type autofs 
(rw,relatime,fd=31,pgrp=1,timeout=0,minproto=5,maxproto=5,direct)
  debugfs on /sys/kernel/debug type debugfs (rw,relatime)
  fusectl on /sys/fs/fuse/connections type fusectl (rw,relatime)
  rpool/home on /home type zfs (rw,nosuid,noatime,xattr,noacl)
  rpool/home/fredrik on /home/fredrik type zfs (rw,nosuid,noatime,xattr,noacl)
  rpool/home/root on /root type zfs (rw,nosuid,noatime,xattr,noacl)
  rpool/srv on /srv type zfs (rw,noatime,xattr,noacl)
  rpool/var/cache on /var/cache type zfs (rw,nosuid,noexec,noatime,xattr,noacl)
  rpool/var/log on /var/log type zfs (rw,nosuid,noexec,noatime,xattr,noacl)
  rpool/var/spool on /var/spool type zfs (rw,nosuid,noexec,noatime,xattr,noacl)
  rpool/var/tmp on /var/tmp type zfs (rw,nosuid,noatime,xattr,noacl)
  tmpfs on /run/user/1000 type tmpfs 
(rw,nosuid,nodev,relatime,size=1623576k,mode=700,uid=1000,gid=1000)
  binfmt_misc on /proc/sys/fs/binfmt_misc type binfmt_misc (rw,relatime)
  tracefs on /sys/kernel/debug/tracing type tracefs (rw,relatime)

  cat /proc/mounts 
  sysfs /sys sysfs rw,nosuid,nodev,noexec,relatime 0 0
  proc /proc proc rw,nosuid,nodev,noexec,relatime 0 0
  udev /dev devtmpfs 
rw,nosuid,relatime,size=8066020k,nr_inodes=2016505,mode=755 0 0
  devpts /dev/pts devpts rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000 
0 0
  tmpfs /run tmpfs rw,nosuid,noexec,relatime,size=1623576k,mode=755 0 0
  rpool/ROOT/ubuntu / zfs rw,relatime,xattr,noacl 0 0
  securityfs /sys/kernel/security securityfs rw,nosuid,nodev,noexec,relatime 0 0
  tmpfs /dev/shm tmpfs rw,nosuid,nodev 0 0
  tmpfs /run/lock tmpfs rw,nosuid,nodev,noexec,relatime,size=5120k 0 0
  tmpfs /sys/fs/cgroup tmpfs ro,nosuid,nodev,noexec,mode=755 0 0
  cgroup /sys/fs/cgroup/systemd cgroup 
rw,nosuid,nodev,noexec,relatime,xattr,release_agent=/lib/systemd/systemd-cgroups-agent,name=systemd
 0 0
  pstore /sys/fs/pstore pstore rw,nosuid,nodev,noexec,relatime 0 0
  cgroup /sys/fs/cgroup/freezer cgroup rw,nosuid,nodev,noexec,relatime,freezer 
0 0
  cgroup /sys/fs/cgroup/blkio cgroup rw,nosuid,nodev,noexec,relatime,blkio 0 0
  cgroup /sys/fs/cgroup/net_cls,net_prio cgroup 
rw,nosuid,nodev,noexec,relatime,net_cls,net_prio 0 0
  cgroup /sys/fs/cgroup/memory cgroup rw,nosuid,nodev,noexec,relatime,memory 0 0
  cgroup /sys/fs/cgroup/hugetlb cgroup rw,nosuid,nodev,noexec,relatime,hugetlb 
0 0
  cgroup /sys/fs/cgroup/cpu,cpuacct cgroup 
rw,nosuid,nodev,noexec,relatime,cpu,cpuacct 0 0
  cgroup /sys/fs/cgroup/pids cgroup rw,nosuid,nodev,noexec,relatime,pids 0 0
  cgroup /sys/fs/cgroup/devices cgroup rw,nosuid,nodev,noexec,relatime,devices 
0 0
  cgroup /sys/fs/cgroup/perf_event cgroup 
rw,nosuid,nodev,noexec,relatime,perf_event 0 0
  cgroup /sys/fs/cgroup/cpuset cgroup rw,nosuid,nodev,noexec,relatime,cpuset 0 0
  mqueue /dev/mqueue mqueue rw,relatime 0 0
  hugetlbfs /dev/hugepages hugetlbfs rw,relatime 0 0
  systemd-1 /proc/sys/fs/binfmt_misc autofs 
rw,relatime,fd=31,pgrp=1,timeout=0,minproto=5,maxproto=5,direct 0 0
  debugfs /sys/kernel/debug debugfs rw,relatime 0 0
  fusectl /sys/fs/fuse/connections fusectl rw,relatime 0 0
  rpool/home /home zfs rw,nosuid,noatime,xattr,noacl 0 0
  rpool/home/fredrik /home/fredrik zfs rw,nosuid,noatime,xattr,noacl 0 0
  rpool/home/root /root zfs rw,nosuid,noatime,xattr,noacl 0 0
  rpool/srv /srv zfs rw,noatime,xattr,noacl 0 0
  rpool/var/cache /var/cache zfs rw,nosuid,noexec,noatime,xattr,noacl 0 0
  rpool/var/log /var/log zfs rw,nosuid,noexec,noatime,xattr,noacl 0 0
  rpool/var/spool /var/spool zfs rw,nosuid,noexec,noatime,xattr,noacl 0 0
  rpool/var/tmp /var/tmp zfs rw,nosuid,noatime,xattr,noacl 0 0
  tmpfs /run/user/1000 tmpfs 
rw,nosuid,nodev,relatime,size=1623576k,mode=700,uid=1000,gid=1000 0 0
  binfmt_misc /proc/sys/fs/binfmt_misc binfmt_misc rw,relatime 0 0
  tracefs /sys/kernel/debug/tracing tracefs rw,relatime 0 0

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/initramfs-tools/+bug/1661629/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to     : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to