** Changed in: unattended-upgrades (Ubuntu Bionic)
Status: Fix Committed => In Progress
** Changed in: unattended-upgrades (Ubuntu Bionic)
Assignee: (unassigned) => Balint Reczey (rbalint)
** Description changed:
[Impact]
* Reports from u-u incorrectly list packages from non-upgradable
origins as "Packages with upgradable origin but kept back"
- * The incorrectly the packages incorrectly is a result of
+ * Listing the packages incorrectly is a result of
is_pkgname_in_blacklist() having a side effect and removing the side
effect is part of fixing LP: #1396787 which fix is also being SRU-d.
* The fix is removing the side effect of is_pkgname_in_blacklist()
[Test Case]
* There is a build-time test in test/test_blacklisted_wrong_origin.py
* To reproduce the original problem set up a system where all security
updates are installed but ebtables (from bionic-updates) is not updated:
$ sudo unattended-upgrade --verbose
- Initial blacklisted packages:
- Initial whitelisted packages:
+ Initial blacklisted packages:
+ Initial whitelisted packages:
Starting unattended upgrades script
Allowed origins are: o=Ubuntu,a=bionic, o=Ubuntu,a=bionic-security,
o=UbuntuESM,a=bionic
No packages found that can be upgraded unattended and no pending auto-removals
$ sudo apt upgrade
Reading package lists... Done
- Building dependency tree
+ Building dependency tree
Reading state information... Done
Calculating upgrade... Done
The following packages will be upgraded:
- apt apt-utils ebtables initramfs-tools initramfs-tools-bin
initramfs-tools-core libapt-inst2.0 libapt-pkg5.0
- liblxc-common liblxc1 libpython3-stdlib lxcfs lxd lxd-client netplan.io
networkd-dispatcher nplan
- python-apt-common python3 python3-apt python3-minimal
python3-update-manager snapd squashfs-tools
- unattended-upgrades update-manager-core update-notifier-common
+ apt apt-utils ebtables initramfs-tools initramfs-tools-bin
initramfs-tools-core libapt-inst2.0 libapt-pkg5.0
+ liblxc-common liblxc1 libpython3-stdlib lxcfs lxd lxd-client netplan.io
networkd-dispatcher nplan
+ python-apt-common python3 python3-apt python3-minimal
python3-update-manager snapd squashfs-tools
+ unattended-upgrades update-manager-core update-notifier-common
27 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Need to get 24.1 MB of archives.
After this operation, 1454 kB of additional disk space will be used.
Do you want to continue? [Y/n] n
Abort.
* blacklist ebtables, set up emails from u-u, then run u-u again:
$ sudo echo 'Unattended-Upgrade::Package-Blacklist {"ebtables";};' >
/etc/apt/apt.conf.d/51unattended-upgrades-blacklist-ebtables
$ sudo echo 'Unattended-Upgrade::Mail "root";' >
/etc/apt/apt.conf.d/51unattended-upgrades-mail
$ sudo unattended-upgrade --verbose
Initial blacklisted packages: ebtables
- Initial whitelisted packages:
+ Initial whitelisted packages:
Starting unattended upgrades script
Allowed origins are: o=Ubuntu,a=bionic, o=Ubuntu,a=bionic-security,
o=UbuntuESM,a=bionic
- Packages that will be upgraded:
+ Packages that will be upgraded:
* Observe ebtables listed as being kept back and having upgradable origin
with buggy u-u:
$ sudo cat /var/mail/mail
...
Packages with upgradable origin but kept back:
- ebtables=20
+ ebtables=20
...
* Upgrade u-u to a fixed version and run it, observing ebtables to be
not listed as having upgradable origin
-
[Regression Potential]
* Regressions may make packages incorrectly missing from u-u's report,
but the autopkgtests also cover that to some extent.
[Other Info]
* Original report: https://github.com/mvo5/unattended-
upgrades/issues/116
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to unattended-upgrades in
Ubuntu.
https://bugs.launchpad.net/bugs/1781176
Title:
Blacklisted packages are included in the "upgradable origin", while
they should not
Status in unattended-upgrades:
Fix Released
Status in unattended-upgrades package in Ubuntu:
Fix Released
Status in unattended-upgrades source package in Bionic:
In Progress
Bug description:
[Impact]
* Reports from u-u incorrectly list packages from non-upgradable
origins as "Packages with upgradable origin but kept back"
* Listing the packages incorrectly is a result of
is_pkgname_in_blacklist() having a side effect and removing the side
effect is part of fixing LP: #1396787 which fix is also being SRU-d.
* The fix is removing the side effect of is_pkgname_in_blacklist()
[Test Case]
* There is a build-time test in test/test_blacklisted_wrong_origin.py
* To reproduce the original problem set up a system where all security
updates are installed but ebtables (from bionic-updates) is not updated:
$ sudo unattended-upgrade --verbose
Initial blacklisted packages:
Initial whitelisted packages:
Starting unattended upgrades script
Allowed origins are: o=Ubuntu,a=bionic, o=Ubuntu,a=bionic-security,
o=UbuntuESM,a=bionic
No packages found that can be upgraded unattended and no pending auto-removals
$ sudo apt upgrade
Reading package lists... Done
Building dependency tree
Reading state information... Done
Calculating upgrade... Done
The following packages will be upgraded:
apt apt-utils ebtables initramfs-tools initramfs-tools-bin
initramfs-tools-core libapt-inst2.0 libapt-pkg5.0
liblxc-common liblxc1 libpython3-stdlib lxcfs lxd lxd-client netplan.io
networkd-dispatcher nplan
python-apt-common python3 python3-apt python3-minimal
python3-update-manager snapd squashfs-tools
unattended-upgrades update-manager-core update-notifier-common
27 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Need to get 24.1 MB of archives.
After this operation, 1454 kB of additional disk space will be used.
Do you want to continue? [Y/n] n
Abort.
* blacklist ebtables, set up emails from u-u, then run u-u again:
$ sudo echo 'Unattended-Upgrade::Package-Blacklist {"ebtables";};' >
/etc/apt/apt.conf.d/51unattended-upgrades-blacklist-ebtables
$ sudo echo 'Unattended-Upgrade::Mail "root";' >
/etc/apt/apt.conf.d/51unattended-upgrades-mail
$ sudo unattended-upgrade --verbose
Initial blacklisted packages: ebtables
Initial whitelisted packages:
Starting unattended upgrades script
Allowed origins are: o=Ubuntu,a=bionic, o=Ubuntu,a=bionic-security,
o=UbuntuESM,a=bionic
Packages that will be upgraded:
* Observe ebtables listed as being kept back and having upgradable origin
with buggy u-u:
$ sudo cat /var/mail/mail
...
Packages with upgradable origin but kept back:
ebtables=20
...
* Upgrade u-u to a fixed version and run it, observing ebtables to be
not listed as having upgradable origin
[Regression Potential]
* Regressions may make packages incorrectly missing from u-u's
report, but the autopkgtests also cover that to some extent.
[Other Info]
* Original report: https://github.com/mvo5/unattended-
upgrades/issues/116
To manage notifications about this bug go to:
https://bugs.launchpad.net/unattended-upgrades/+bug/1781176/+subscriptions
--
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help : https://help.launchpad.net/ListHelp
