On Wed, 19 Sep 2018 at 22:01, Christian Ehrhardt < 1786...@bugs.launchpad.net> wrote:
> Hi, > first of all this package seems to have quite some issues in the merges > that are done - it doesn't list all remaining changes and the i2c blacklist > is one of them. > It comes from like back in 2005 and I agree, it might or is safe to be > removed. > > Thanks to Stefan Bader for cleaning this up, as the MP linked here has > e.g. on changelog entries. > I'd ack to his branch at [1] for Cosmic, is it would be an MP to ack on. > Thanks! > > But for the actual sponsoring, as I never really touched kmod before I'd > be happy if you'd ask one of the foundations Team that is here this week > that touched it recently as they might have extra considerations. OTOH > the change really looks right for cosmic IMHO, so if no one responds get > back to me. > > SRUs of this are quite a different topic for the following reasons: > - if the issues still exists, it might regress somebody due to the SRU > then. > - If you can prove that the old issue really does no more exist with e.g. > the oldest kernel in Bionic, then it might be done. But you'd have to > outline that in detail when completing the SRU template for this bug [2] > Without the prove I'd be concerned and as a SRU member would reject it, so > really make sure you > get this documented right. > I have added the SRU justification, hope that helps. ** Description changed: + SRU justification + ============ + + [Impact] + Many modern notebooks need i2c-i801 kernel module to function, but it is blacklisted by /etc/modprobe/blacklist.conf, which gives a very poor user experience. + + [Test case] + 1. Install Ubuntu + 2. Check touchpad works or not + 3. Install the fixed kmod package + 4. Confirm touchpad works + + [Regression Potential] + i2c-i801 was blacklisted due to bug 16602. The user complains an HP Compaq nc6000 notebook cannot suspend without blacklisting i2c-i801. While this is a way to workaround the suspend issue, the proper fix should be in linux kernel. Since nc6000 was a machine sold in 2004, it is too difficult to find someone to verify if it will regress due to this SRU. The rationale to blacklist it is: https://bugs.launchpad.net/ubuntu/+source/hotplug/+bug/16602/comments/5, however it is no longer valid nowadays on modern computers. + + Besides, there look like to be a quirk in linux kernel that fixes it: + https://github.com/torvalds/linux/blame/master/drivers/pci/quirks.c#L1434 + + [Other Info] + rationale of i2c_i801 driver blacklist: https://answers.launchpad.net/ubuntu/+source/kmod/+question/269329 + + ----------------------------------------------------------------------------------------------- + Original bug report: + We have a Lenovo Thinkpad machine that requires i2c-i801 kernel module to work, but it is listed in /etc/modprobe/blacklist.conf in Ubuntu. To use the touchpad, users have to remove the i2c-i801 line manually. i2c-i801 in blacklist.conf is a very old workaround to fix HP compaq nc6000 (Bug #16602), this module should be removed from blacklist. There is also another bug (Bug #1475945) that needs this module for Acer trackpad to work. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to kmod in Ubuntu. https://bugs.launchpad.net/bugs/1786574 Title: remove i2c-i801 from blacklist Status in HWE Next: New Status in OEM Priority Project: New Status in kmod package in Ubuntu: Confirmed Status in kmod source package in Xenial: Confirmed Status in kmod source package in Bionic: Confirmed Status in kmod source package in Cosmic: Confirmed Bug description: SRU justification ============ [Impact] Many modern notebooks need i2c-i801 kernel module to function, but it is blacklisted by /etc/modprobe/blacklist.conf, which gives a very poor user experience. [Test case] 1. Install Ubuntu 2. Check touchpad works or not 3. Install the fixed kmod package 4. Confirm touchpad works [Regression Potential] i2c-i801 was blacklisted due to bug 16602. The user complains an HP Compaq nc6000 notebook cannot suspend without blacklisting i2c-i801. While this is a way to workaround the suspend issue, the proper fix should be in linux kernel. Since nc6000 was a machine sold in 2004, it is too difficult to find someone to verify if it will regress due to this SRU. The rationale to blacklist it is: https://bugs.launchpad.net/ubuntu/+source/hotplug/+bug/16602/comments/5, however it is no longer valid nowadays on modern computers. Besides, there look like to be a quirk in linux kernel that fixes it: https://github.com/torvalds/linux/blame/master/drivers/pci/quirks.c#L1434 [Other Info] rationale of i2c_i801 driver blacklist: https://answers.launchpad.net/ubuntu/+source/kmod/+question/269329 ----------------------------------------------------------------------------------------------- Original bug report: We have a Lenovo Thinkpad machine that requires i2c-i801 kernel module to work, but it is listed in /etc/modprobe/blacklist.conf in Ubuntu. To use the touchpad, users have to remove the i2c-i801 line manually. i2c-i801 in blacklist.conf is a very old workaround to fix HP compaq nc6000 (Bug #16602), this module should be removed from blacklist. There is also another bug (Bug #1475945) that needs this module for Acer trackpad to work. To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/1786574/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
