On Tue, Jun 09, 2020 at 09:04:00AM -0000, Didier Roche wrote: > + Other use case: > + On a non ZFS installation : > + On a non ZFS installation with ZSys installed :
Can I suggest a ZFS installation that doesn't have zsys installed, as well? There's at least a dozen of us that used the guide from the ZFS On Linux wiki on running Ubuntu on ZFS on LUKS, and may not have zsys installed (I'm a bit afraid of trying it myself, perhaps assumptions it makes aren't assumptions I made.) Thanks -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to shadow in Ubuntu. https://bugs.launchpad.net/bugs/1870058 Title: Collect deleted users Status in shadow package in Ubuntu: Fix Released Status in zsys package in Ubuntu: Fix Released Status in shadow source package in Focal: New Status in zsys source package in Focal: New Bug description: [Impact] * Deleting users were preserving corresponding ZFS user datasets, without marking them for cleanup. * This is covered by dedicated use cases. [Test Case] 1. Ensure you have a foo user: 2. Run userdel --remove foo 3. Check that rpool/USERDATA/foo_xxxx has its content removed and is not mounted 4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_xxxx is not associated with current system dataset --- Other use case: 1.Ensure you have a foo user: 2. Run userdel foo 3. Check that rpool/USERDATA/foo_xxxx still has its content, but is not mounted. 4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_xxxx is not associated with current system dataset --- On a non ZFS installation : 1. Ensure you have a foo user: 2. Run userdel --remove foo 3. The user is deleted, no error occured. --- On a non ZFS installation with ZSys installed : 1. Ensure you have a foo user: 2. Run userdel --remove foo 3. The user is deleted, no error occured. [Regression Potential] * A new hidden command is added, triggered by userdel. * Tests are covering this new command and GRPC request. * The methodology is similar to useradd and usermod. The dependency between shadow and zsys is weak on purpose: - the ZSys hidden command is available and is a no-op if not called - if calling the command failed on userdel, nothing is done on ZSys side, but the code path is similar to ZSys not being installed or running on a non ZFS system. ---- Ideally, we would untag them as part of GC so that we can clean them up later. However, those can be linked to states on other pools with same pool name than targetted one, and it will be hard to match them. Give a command for users to see them in status and then manually remove suspicious datasets ? To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/1870058/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
