@brian-murray,
Bug description is updated. Please keep me posted if it needs more
information. Thanks
** Description changed:
+ [Impact]
+
+ dump_acpi_tables.py does not always generate 4-char table names (which
+ is defined by ACPI spec) and can miss or duplicate data of ACPI tables
+ in /sys/firmware/acpi/tables.
+
+
+ [Test Case]
+ Tested with ACPI tables from Dell's Precision 3530. The outputs are almost
the same as ones from "acpidump". The difference is the order of ACPI tables in
the output but the order is not important.
+
+ [Regression Potential]
+
+ Formats were changed to be the same as outputs from "acpidump", but
+ known tools, such as acpiexec and fwts, by default reads outputs from
+ acpidump and they do not reply on spaces and upper/lower cases.
+
+ [Other Info]
+
+ See original bug reports as below:
+
dump_acpi_tables.py generates log files that is similar as the output
from "acpidump" in acpica-tools. The output can be passed to other
utilities in acpica-tools and fwts.
It, however, has some subtle differences and some errors.
Summary:
1. ACPI tables have 4-char signatures - meaning SSDT's are SSDT, not
SSDT1, SSDT2 and so on. Each table is unique by its table ID.
Original:
SSDT1, SSDT2, SSDT3 ...
Changed:
SSDT, SSDT, SSDT ...
2. (Minor) acpidump outputs are all in upper cases
3. (Minor) acpidump offset are aligned by data, not address
Original:
FFF0: 53 41 56 43 52 44 43 41 4E 43 52 4E 72 4E 50 4D SAVCRDCANCRNrNPM
10000: 56 0A 04 00 0C FC FF FF FF 0A 03 0A 03 52 44 43 V............RDC
Changed:
FFF0: 53 41 56 43 52 44 43 41 4E 43 52 4E 72 4E 50 4D SAVCRDCANCRNrNPM
10000: 56 0A 04 00 0C FC FF FF FF 0A 03 0A 03 52 44 43 V............RDC
4. (Bug) dump_acpi_tables.py generates an extra line when data sizes are
multiple of 16 bytes
Original:
05F0: 30 30 0B 00 08 00 A4 48 50 53 44 A4 53 50 53 44 00.....HPSD.SPSD
05F0: 30 30 0B 00 08 00 A4 48 50 53 44 A4 53 50 53 44
00.....HPSD.SPSD
Corrected:
05F0: 30 30 0B 00 08 00 A4 48 50 53 44 A4 53 50 53 44 00.....HPSD.SPSD
5. (Bug) dump_acpi_tables.py misses an line when data sizes are multiple
of 15 bytes
Original:
07E0: 42 0A 87 5C 2F 03 5F 53 42 5F 55 42 54 43 43 43 B..\/._SB_UBTCCC
Corrected:
07E0: 42 0A 87 5C 2F 03 5F 53 42 5F 55 42 54 43 43 43 B..\/._SB_UBTCCC
07F0: 49 33 86 5C 2E 5F 53 42 5F 55 42 54 43 0A 80 I3.\._SB_UBTC..
** Description changed:
[Impact]
- dump_acpi_tables.py does not always generate 4-char table names (which
- is defined by ACPI spec) and can miss or duplicate data of ACPI tables
- in /sys/firmware/acpi/tables.
-
+ dump_acpi_tables.py does not always generate 4-char table names (which
+ is defined by ACPI spec), and it can miss or duplicate data of ACPI
+ tables in /sys/firmware/acpi/tables.
[Test Case]
- Tested with ACPI tables from Dell's Precision 3530. The outputs are almost
the same as ones from "acpidump". The difference is the order of ACPI tables in
the output but the order is not important.
+ Tested with ACPI tables from Dell's Precision 3530. The outputs are almost
the same as ones from "acpidump". The difference is the order of ACPI tables in
the output but the order is not important.
+
+ 1. run dump_acpi_tables.py
+ 2. run acpidump
+ 3. compare the outputs
+
+ Note: acpidump is from acpica-tools
[Regression Potential]
- Formats were changed to be the same as outputs from "acpidump", but
+ Formats were changed to be the same as outputs from "acpidump", but
known tools, such as acpiexec and fwts, by default reads outputs from
acpidump and they do not reply on spaces and upper/lower cases.
[Other Info]
- See original bug reports as below:
+ See original bug reports as below:
dump_acpi_tables.py generates log files that is similar as the output
from "acpidump" in acpica-tools. The output can be passed to other
utilities in acpica-tools and fwts.
It, however, has some subtle differences and some errors.
Summary:
1. ACPI tables have 4-char signatures - meaning SSDT's are SSDT, not
SSDT1, SSDT2 and so on. Each table is unique by its table ID.
Original:
SSDT1, SSDT2, SSDT3 ...
Changed:
SSDT, SSDT, SSDT ...
2. (Minor) acpidump outputs are all in upper cases
3. (Minor) acpidump offset are aligned by data, not address
Original:
FFF0: 53 41 56 43 52 44 43 41 4E 43 52 4E 72 4E 50 4D SAVCRDCANCRNrNPM
10000: 56 0A 04 00 0C FC FF FF FF 0A 03 0A 03 52 44 43 V............RDC
Changed:
FFF0: 53 41 56 43 52 44 43 41 4E 43 52 4E 72 4E 50 4D SAVCRDCANCRNrNPM
10000: 56 0A 04 00 0C FC FF FF FF 0A 03 0A 03 52 44 43 V............RDC
4. (Bug) dump_acpi_tables.py generates an extra line when data sizes are
multiple of 16 bytes
Original:
05F0: 30 30 0B 00 08 00 A4 48 50 53 44 A4 53 50 53 44 00.....HPSD.SPSD
05F0: 30 30 0B 00 08 00 A4 48 50 53 44 A4 53 50 53 44
00.....HPSD.SPSD
Corrected:
05F0: 30 30 0B 00 08 00 A4 48 50 53 44 A4 53 50 53 44 00.....HPSD.SPSD
5. (Bug) dump_acpi_tables.py misses an line when data sizes are multiple
of 15 bytes
Original:
07E0: 42 0A 87 5C 2F 03 5F 53 42 5F 55 42 54 43 43 43 B..\/._SB_UBTCCC
Corrected:
07E0: 42 0A 87 5C 2F 03 5F 53 42 5F 55 42 54 43 43 43 B..\/._SB_UBTCCC
07F0: 49 33 86 5C 2E 5F 53 42 5F 55 42 54 43 0A 80 I3.\._SB_UBTC..
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to apport in Ubuntu.
https://bugs.launchpad.net/bugs/1883027
Title:
dump_acpi_tables.py: fix incorrect output and change format
Status in Apport:
Confirmed
Status in apport package in Ubuntu:
In Progress
Status in apport source package in Focal:
Confirmed
Status in apport source package in Groovy:
In Progress
Bug description:
[Impact]
dump_acpi_tables.py does not always generate 4-char table names
(which is defined by ACPI spec), and it can miss or duplicate data of
ACPI tables in /sys/firmware/acpi/tables.
[Test Case]
Tested with ACPI tables from Dell's Precision 3530. The outputs are almost
the same as ones from "acpidump". The difference is the order of ACPI tables in
the output but the order is not important.
1. run dump_acpi_tables.py
2. run acpidump
3. compare the outputs
Note: acpidump is from acpica-tools
[Regression Potential]
Formats were changed to be the same as outputs from "acpidump", but
known tools, such as acpiexec and fwts, by default reads outputs from
acpidump and they do not reply on spaces and upper/lower cases.
[Other Info]
See original bug reports as below:
dump_acpi_tables.py generates log files that is similar as the output
from "acpidump" in acpica-tools. The output can be passed to other
utilities in acpica-tools and fwts.
It, however, has some subtle differences and some errors.
Summary:
1. ACPI tables have 4-char signatures - meaning SSDT's are SSDT, not
SSDT1, SSDT2 and so on. Each table is unique by its table ID.
Original:
SSDT1, SSDT2, SSDT3 ...
Changed:
SSDT, SSDT, SSDT ...
2. (Minor) acpidump outputs are all in upper cases
3. (Minor) acpidump offset are aligned by data, not address
Original:
FFF0: 53 41 56 43 52 44 43 41 4E 43 52 4E 72 4E 50 4D SAVCRDCANCRNrNPM
10000: 56 0A 04 00 0C FC FF FF FF 0A 03 0A 03 52 44 43 V............RDC
Changed:
FFF0: 53 41 56 43 52 44 43 41 4E 43 52 4E 72 4E 50 4D SAVCRDCANCRNrNPM
10000: 56 0A 04 00 0C FC FF FF FF 0A 03 0A 03 52 44 43 V............RDC
4. (Bug) dump_acpi_tables.py generates an extra line when data sizes
are multiple of 16 bytes
Original:
05F0: 30 30 0B 00 08 00 A4 48 50 53 44 A4 53 50 53 44 00.....HPSD.SPSD
05F0: 30 30 0B 00 08 00 A4 48 50 53 44 A4 53 50 53 44
00.....HPSD.SPSD
Corrected:
05F0: 30 30 0B 00 08 00 A4 48 50 53 44 A4 53 50 53 44 00.....HPSD.SPSD
5. (Bug) dump_acpi_tables.py misses an line when data sizes are
multiple of 15 bytes
Original:
07E0: 42 0A 87 5C 2F 03 5F 53 42 5F 55 42 54 43 43 43 B..\/._SB_UBTCCC
Corrected:
07E0: 42 0A 87 5C 2F 03 5F 53 42 5F 55 42 54 43 43 43 B..\/._SB_UBTCCC
07F0: 49 33 86 5C 2E 5F 53 42 5F 55 42 54 43 0A 80 I3.\._SB_UBTC..
To manage notifications about this bug go to:
https://bugs.launchpad.net/apport/+bug/1883027/+subscriptions
--
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help : https://help.launchpad.net/ListHelp
