** Description changed: + [ Impact ] + + * An explanation of the effects of the bug on users and + + * justification for backporting the fix to the stable release. + + * In addition, it is helpful, but not required, to include an + explanation of how the upload fixes this bug. + + [ Test Plan ] + + * detailed instructions how to reproduce the bug + + * these should allow someone who is not familiar with the affected + package to reproduce the bug and verify that the updated package fixes + the problem. + + * if other testing is appropriate to perform before landing this update, + this should also be described here. + + [ Where problems could occur ] + + * Think about what the upload changes in the software. Imagine the change is + wrong or breaks something else: how would this show up? + + * It is assumed that any SRU candidate patch is well-tested before + upload and has a low overall risk of regression, but it's important + to make the effort to think about what ''could'' happen in the + event of a regression. + + * This must '''never''' be "None" or "Low", or entirely an argument as to why + your upload is low risk. + + * This both shows the SRU team that the risks have been considered, + and provides guidance to testers in regression-testing the SRU. + + [ Other Info ] + + * Anything else you think is useful to include + * Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board + * and address these questions in advance + + [ Original Description] + The Bionic DEP8 tests for iptables are in bad shape[1], even in the migration-reference/0 run. There are two types of failures: a) some commands have an exit status of 1 when called with the -h (for help) option, which is what some tests do b) iptables-compat-save (and its IPv6 counterpart) also exit with status 1, even when there are chains/tables to save I'll propose: a) grep the help output instead of relying on the exit status b) call the command with the -d (dump) option. That doesn't exit 0 in the success case, and actually dumps data when there are tables to do so - 1. https://autopkgtest.ubuntu.com/packages/i/iptables/bionic/amd64
-- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to iptables in Ubuntu. https://bugs.launchpad.net/bugs/2019022 Title: Bionic dep8 tests are failing Status in iptables package in Ubuntu: Fix Released Status in iptables source package in Bionic: In Progress Bug description: [ Impact ] This bug does not affect users directly, but it's a problem everytime iptables is SRUed to Bionic. We could hint the DEP8 tests, in which case they would all be ignored (uncluding the ones that actually work), or fix it. By itself, fixing DEP8 is not worth an SRU, but since we are fixing a segfault (in #1992454), we can ship the DEP8 fixes with it and make future SRUs easier and of better quality (since the tests now run correctly). The actual fixes are two: - since many iptables commands exit non-zero when the help parameter is given (-h/--help), instead of relying on that, we grep the output. Since bash's pipefail option is not set, it's the grep exit status that will be checked. - the iptables-compat-save is now being called with the -d (dump) option, which works for what the test wants, and doesn't exit 1 for no reason. Later versions of iptables have either flipped the exit status of the -h option (but not for all commands, annoyingly), so this fix is not needed after bionic. In other cases, the problematic test was just removed from d/t/control. [ Test Plan ] Verify in the autopkgtest report that the DEP8 tests ran and are all green. [ Where problems could occur ] This is fixing the existing DEP8 tests, which have been red for bionic since ever. \ [ Other Info ] Not at this time. [ Original Description] The Bionic DEP8 tests for iptables are in bad shape[1], even in the migration-reference/0 run. There are two types of failures: a) some commands have an exit status of 1 when called with the -h (for help) option, which is what some tests do b) iptables-compat-save (and its IPv6 counterpart) also exit with status 1, even when there are chains/tables to save I'll propose: a) grep the help output instead of relying on the exit status b) call the command with the -d (dump) option. That doesn't exit 0 in the success case, and actually dumps data when there are tables to do so 1. https://autopkgtest.ubuntu.com/packages/i/iptables/bionic/amd64 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/iptables/+bug/2019022/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
