Hello Dominic, or anyone else affected,

Accepted util-linux into focal-proposed. The package will build now and
be available at https://launchpad.net/ubuntu/+source/util-
linux/2.34-0.1ubuntu9.4 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
focal to verification-done-focal. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-focal. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: util-linux (Ubuntu Focal)
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to util-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2015355

Title:
  Please backport patches for false atari partition detection to Ubuntu
  20.04

Status in util-linux package in Ubuntu:
  Fix Released
Status in util-linux source package in Focal:
  Fix Committed

Bug description:
  [Impact]

  The partition detection logic in libblkid1 can falsely report the
  presence of an atari partition. One place where this has a practical
  impact is in kubernetes where mount-utils will refuse to format the
  device (https://github.com/kubernetes/mount-
  utils/blob/732a08ae47571516020ef99c303c70c1fa5b3e6c/mount_linux.go#L437-L441).

  [Test Plan]

  * Create a new qcow2 disk image:

  $ qemu-img create -f qcow2 test.img 20G

  * Boot a focal ISO with QEMU/KVM as if installing to test.img:

  $ qemu-system-x86_64 -enable-kvm -m 4096 -name test -drive
  file=test.img,format=qcow2 -net nic,model=virtio -net
  user,hostfwd=tcp::1022-:22 -vga virtio -cdrom ubuntu-20.04.6-desktop-
  amd64.iso

  * Using the live environment, format the empty disk. These particular
  commands were given as a reproducer on the upstream bug report
  (https://github.com/util-linux/util-linux/issues/1116).

  $ parted -s /dev/sda -- mklabel msdos
  $ parted -s /dev/sda -- mkpart primary 0% 10% mkpart primary 10% 30%

  * Run wipefs on /dev/sda to list partitions. On an affected machine,
  an atari partition will be listed. On a fixed machine, the incorrect
  atari listing will be gone.

  $ wipefs /dev/sda
  DEVICE OFFSET TYPE  UUID LABEL
  sda    0x1fe  dos
  sda    0x1d2  atari

  [Where problems could occur]

  These patches specifically address the atari prober logic in libblkid.
  Therefore, if we saw regressions it would be related to detecting
  atari partitions with libblkid. This would potentially impact tools
  such as wipefs and blkid, or any other tool that uses libblkid1 for
  this purpose.

  [Original Description]

  There are three patches in util-linux upstream that were released in
  util-linux 2.37 and prevent false detection of the atari partition
  table with blkid and wipefs. We see this mostly on LUKS devices
  initialised via luksFormat reporting there is an atari partition table
  on the device when it is empty. This causes issues in various places,
  but one key example for us is in kubernetes where mount-utils will
  refuse to format the device (https://github.com/kubernetes/mount-
  utils/blob/732a08ae47571516020ef99c303c70c1fa5b3e6c/mount_linux.go#L437-L441)

  RedHat backported these fixes to RHEL 8 under
  https://bugzilla.redhat.com/show_bug.cgi?id=2060030 and it would be
  helpful if Ubuntu also backported them to Ubuntu 20.04 which is still
  running util-linux 2.34

  The request is to backport patches based on the
  https://github.com/util-linux/util-linux/issues/1159 upstream report.

  Upstream commits to cherry-pick the changes to 
libblkid/src/partitions/atari.c from:
  2cc76d50d7a14bef8e7b07fab11b26c9e49d36a2
  282ceadc3a72fc07dd0388b8880fd751490bb87f
  c70b4f2a5b99876d230b8f4f413c3bb3ee6647f1

  # lsb_release -a
  Distributor ID: Ubuntu
  Description:    Ubuntu 20.04.6 LTS
  Release:        20.04
  Codename:       focal
  # blkid -V
  blkid from util-linux 2.34  (libblkid 2.34.0, 14-Jun-2019)
  # blkid -p -s TYPE -s PTTYPE -o export 
/dev/mapper/pvc-7b331195-cd5a-4ab6-8fdc-552af4b9139d_encrypted
  DEVNAME=dev/mapper/pvc-7b331195-cd5a-4ab6-8fdc-552af4b9139d_encrypted
  PTTYPE=atari
  # lsblk
  ...
  sdc                                                    crypto_LUKS            
     a79d2982-74f2-44c7-bb29-460768ebfe64
  `-3600a09803830474a735d4c63744c4a56                    crypto_LUKS            
     a79d2982-74f2-44c7-bb29-460768ebfe64
    `-pvc-7b331195-cd5a-4ab6-8fdc-552af4b9139d_encrypted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/2015355/+subscriptions


-- 
Mailing list: https://launchpad.net/~touch-packages
Post to     : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to