Reviewed: https://review.opendev.org/c/openstack/oslo.utils/+/850099
Committed:
https://opendev.org/openstack/oslo.utils/commit/2319e6d32812ac8244b8dcacee6d1fadfab1c656
Submitter: "Zuul (22348)"
Branch: master
commit 2319e6d32812ac8244b8dcacee6d1fadfab1c656
Author: Takashi Kajinami <tkaji...@redhat.com>
Date: Mon Jul 18 22:18:27 2022 +0900
Remove strict from is_same_callback()
The strict argument has been deprecated since 4.6.0 because it has no
effect in Python >=3.8 [1].
Because now this library supports only Python >=3.8, the logic for old
python versions can be removed.
[1] https://review.opendev.org/c/openstack/oslo.utils/+/750216
Related-Bug: #1841072
Change-Id: I5873c0df347a4e9a8a1fbfcf9f1212af14f7aef2
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to python3-defaults in
Ubuntu.
https://bugs.launchpad.net/bugs/1841072
Title:
test_reflection.CallbackEqualityTest.test_different_instance_callbacks
fails on Python 3.8
Status in oslo.utils:
Fix Released
Status in python-oslo.utils package in Ubuntu:
Fix Released
Status in python3-defaults package in Ubuntu:
Invalid
Bug description:
When running the unit test on Python 3.8, it fails with the following
traceback:
oslo_utils.tests.test_reflection.CallbackEqualityTest.test_different_instance_callbacks
---------------------------------------------------------------------------------------
Captured traceback:
~~~~~~~~~~~~~~~~~~~
b'Traceback (most recent call last):'
b' File "/tmp/oslo.utils/oslo_utils/tests/test_reflection.py", line 156,
in test_different_instance_callbacks'
b' self.assertTrue(reflection.is_same_callback(b.b, c.b,
strict=False))'
b' File
"/tmp/oslo.utils/.tox/py38/lib/python3.8/site-packages/unittest2/case.py", line
702, in assertTrue'
b' raise self.failureException(msg)'
b'AssertionError: False is not true'
b''
This is apparently caused by a behavior change in Python 3.8 due to
[1]. I have confirmed the different behavior by running tests manually
on 3.6, 3.7 (both return True) and 3.8.
According to [2], only taskflow seems to be using that method now, and
it is not changing the default value for the "strict" parameter.
[1] - https://bugs.python.org/issue1617161
[2] - http://codesearch.openstack.org/?q=is_same_callback&i=nope&files=&repos=
To manage notifications about this bug go to:
https://bugs.launchpad.net/oslo.utils/+bug/1841072/+subscriptions
--
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help : https://help.launchpad.net/ListHelp
