On Mon, Apr 22, 2013 at 07:36:18PM -0500, Rob Landley wrote: > On 04/22/2013 05:40:28 PM, Isaac Dunham wrote: > >Hello, > >The kernel maps all occurences of '-' in module names to '_', so > >that if you load a module such as snd-pcm-oss.ko or phc-k8.ko, it > >is presented by lsmod and /proc/modules as module snd_pcm_oss or > >phc_k8. > >Modinfo from module-init-tools makes up for that by reversing the > >logic and treating '-' and '_' as equivalent, while toybox takes > >only the string passed. > > Happy to accept patches, but I'm not currently up to speed on the > corner cases of module loading and haven't got spare brain to fit it > in just now. (If I read through it in the half hour this starbucks > is still open, I won't finish and will forget what I read by > morning.)
Understood. It's not a major issue for me, especially given that I can't boot a (straight | mostly) toybox system yet. > >Another difference is that standard modinfo is documented to > >accept a filename > >as a parameter (modinfo /path/to/module.ko). > > > >Thanks, > >Isaac Dunham > > I only recently added toys/pending and there are a number of third > party contributions I never did properly triage and clean up. > (login.c is another one...) > > Should I move them into pending so we can track them? Not really concerned about this part--however you see fit. > Right now my aboriginal linux build is the main real world test for > this code, and it doesn't do a modular build. (It also doesn't use > login, it does oneit straight to a shell prompt instead.) Presumably > the people who contributed it are using it, but then it works for > them pretty much by definition... > > Thanks for the heads up, > > Rob _______________________________________________ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net