Hi Rob, list,

I knwo its too many mails in one day, but thats due to malfunctioned
mail I had.

Attacehd is the patch for ifconfig.c, fixing issues

1. show_help(), only prints help and continues the execution.
    ifconfig had a SEGFAULT due to this very thing. Modified the
    the ifconfig_main() to return after showing help for ifconfig.

2. In __ display_ifconfig() _ there was typo, corrected the filename to
    "/proc/net/if_inet6".

3. in __ show_iface() _ data was read into toybuf. after this _name_
    pointed inside the toybuf.  This function passed name to __
display_ifconfig() _
    function, which again used the toybuf to read data into. Hence
corrupting the
_name_. Fixed this by making a copy of name and then freeing it after use.

Your inputs are welcome.

regards,
Ashwini Sharma

Attachment: ifconfig.c.patch
Description: Binary data

_______________________________________________
Toybox mailing list
Toybox@lists.landley.net
http://lists.landley.net/listinfo.cgi/toybox-landley.net

Reply via email to