My understanding is that uClibc is dead, and the probe for fallocate
would need to be made more complicated to work for macOS (where we fake
posix_fallocate() in lib/portability.c).
---
 scripts/genconfig.sh   | 5 -----
 toys/other/fallocate.c | 1 -
 2 files changed, 6 deletions(-)
From 95fe4ad46d1b671396a3a07a2d35f0f7d3afbb67 Mon Sep 17 00:00:00 2001
From: Elliott Hughes <e...@google.com>
Date: Tue, 22 Oct 2019 21:49:26 -0700
Subject: [PATCH] fallocate: remove uClibc workaround to benefit macOS.

My understanding is that uClibc is dead, and the probe for fallocate
would need to be made more complicated to work for macOS (where we fake
posix_fallocate() in lib/portability.c).
---
 scripts/genconfig.sh   | 5 -----
 toys/other/fallocate.c | 1 -
 2 files changed, 6 deletions(-)

diff --git a/scripts/genconfig.sh b/scripts/genconfig.sh
index 724888b3..cc2bd764 100755
--- a/scripts/genconfig.sh
+++ b/scripts/genconfig.sh
@@ -52,11 +52,6 @@ EOF
   probesymbol TOYBOX_ICONV -c << EOF
     #include "iconv.h"
 EOF
-  probesymbol TOYBOX_FALLOCATE << EOF
-    #include <fcntl.h>
-
-    int main(int argc, char *argv[]) { return posix_fallocate(0,0,0); }
-EOF
   
   # Android and some other platforms miss utmpx
   probesymbol TOYBOX_UTMPX -c << EOF
diff --git a/toys/other/fallocate.c b/toys/other/fallocate.c
index a7308972..5007effe 100644
--- a/toys/other/fallocate.c
+++ b/toys/other/fallocate.c
@@ -8,7 +8,6 @@ USE_FALLOCATE(NEWTOY(fallocate, ">1l#|o#", TOYFLAG_USR|TOYFLAG_BIN))
 
 config FALLOCATE
   bool "fallocate"
-  depends on TOYBOX_FALLOCATE
   default y
   help
     usage: fallocate [-l size] [-o offset] file
-- 
2.23.0.866.gb869b98d4c-goog

_______________________________________________
Toybox mailing list
Toybox@lists.landley.net
http://lists.landley.net/listinfo.cgi/toybox-landley.net

Reply via email to