On 4/15/22 18:10, enh wrote: > yeah, and it seems to have passed on github CI anyway, so i didn't notice > until > i tried to update AOSP. > > maybe those tests are just skipped on github? > > SKIP: ifconfig (not root) > > yep. (ideally i'd run the tests _twice_ on Android: once as root and once not > as > root, but that's a lot harder and hasn't bitten us _yet_ so "just as root" it > is...)
Root should be a strict superset of the non-root tests. It shouldn't test anything extra NOT as root. > I'll add a comment line. > > thanks! let me know when it's in and i'll try another sync... It's in. Rob _______________________________________________ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net