On Thu, Jul 14, 2016 at 08:35:30PM -0700, Andrey Pronin wrote: > On Thu, Jul 14, 2016 at 09:23:27PM -0600, Jason Gunthorpe wrote: > > On Thu, Jul 14, 2016 at 06:51:36PM -0700, Andrey Pronin wrote: > > > - WARN_ON(chip->groups_cnt != 0); > > > > Nope. > > > > > - const struct attribute_group *groups[3]; > > > + /* up to 4 attribute groups: > > > + * - driver-specific > > > + * - common TPM1.2 and TPM2.0 > > > + * - TPM1.2/2.0-specific > > > + * - ppi > > > + */ > > > + const struct attribute_group *groups[5]; > > > > The prior patch needed to have groups[4], every patch much work. > > > > > + if (priv->phy_ops->attr_group) > > > + chip->groups[chip->groups_cnt++] = priv->phy_ops->attr_group; > > > > I am really not excited about having driver specific sysfs > > files. > > > > What is the justification for this? > > > > Jason > > Justification: give access to vendor-specific properties that are > specific to a particular chip and its registers.
Please come with a vendor specific property or have this part of a series where the need becomes somehow obvious so that we can talk about a real problem and not in an abstract level. Making user API vendor wobbling is almost over my dead body type of thing but given the context there might be alternatives to consider. I honestly don't understand why this was even bundled with TPM2 patch. /Jarkko ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports.http://sdm.link/zohodev2dev _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
