On Tue, Mar 28, 2017 at 06:15:56AM +0000, Winkler, Tomas wrote: > > > > > > On Tue, Mar 21, 2017 at 10:05:36PM +0000, Winkler, Tomas wrote: > > > > On Thu, Mar 16, 2017 at 09:51:33PM -0400, Jérémy Lefaure wrote: > > > > > When PM_SLEEP is disabled crb_pm_suspend and crb_pm_resume are > > not > > > > > used by SET_SYSTEM_SLEEP_PM_OPS even if PM is enabled: > > > > > > > > > > drvers/char/tpm/tpm_crb.c:540:12: warning: ‘crb_pm_suspend’ > > > > > defined but not used [-Wunused-function] static int > > > > > crb_pm_suspend(struct device *dev) > > > > > ^ > > > > > drivers/char/tpm/tpm_crb.c:551:12: warning: ‘crb_pm_resume’ > > > > > defined but not used [-Wunused-function] static int > > > > > crb_pm_resume(struct device *dev) > > > > > ^ > > > > > > > > > > The preprocessor condition should be on CONFIG_PM_SLEEP, not on > > > > CONFIG_PM. > > > > > However, this patch fixes this warning by using __maybe_unused on > > > > > function that are in the preprocessor condition. > > > > > > > > > > Signed-off-by: Jérémy Lefaure <[email protected]> > > > > > > > > Thanks. Please include also [email protected] in the future. > > > > > > > > Reviewed-by: Jarkko Saskkinen <[email protected]> > > > > > > We should go with Arnd's patch, which is actually the same, but it > > > was already reviewed and has better commit messages. > > > Thanks > > > Tomas > > > > You are right about the commit message but where are the Reviewed-by tags? > > Please add mine. > > > [1] > > > > [1] https://patchwork.kernel.org/patch/9633537/ > > > Tomas
I'll keep the existing patch at this point as I do not have time to go through test cycle for another patch. I'm sorry but this came too late. /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
