On Thu, Apr 06, 2017 at 09:44:54AM +0300, Jarkko Sakkinen wrote: > On Thu, Apr 06, 2017 at 09:35:34AM +0300, Jarkko Sakkinen wrote: > > On Wed, Apr 05, 2017 at 01:29:29PM -0700, Petr Vandrovec wrote: > > > Jarkko Sakkinen wrote: > > > > On Wed, Mar 29, 2017 at 12:43:30AM -0700, Petr Vandrovec wrote: > > > > > From: Petr Vandrovec<[email protected]> > > > > > > > > > > When TPM2 log has entries with more than 3 digests, or with digests > > > > > not listed in the log header, log gets misparsed, eventually > > > > > leading to kernel complaint that code tried to vmalloc 512MB of > > > > > memory (I have no idea what would happen on bigger system). > > > > > > > > It would be easier to follow this if you would give a concrete > > > > example of such situation. Since you are contributing this, you > > > > must must have bumped into this, haven't you? > > > > > > Yes. Our firmware reports TPM2 log with 4 digests (SHA1, SHA256, SHA384, > > > SHA512). Current code in kernel skips over first 3 digests only, trying > > > to > > > parse 4th digest as event length, coming to conclusion that entry is > > > hundred > > > of megabytes or few gigabytes long, and then failing to vmalloc() that > > > amount of memory. > > > > > > You can find parsed textual log at > > > https://drive.google.com/open?id=0B7WL11GSMhrQRDBLWjc3bEZQTEk (192KB), and > > > binary log at > > > https://drive.google.com/open?id=0B7WL11GSMhrQQ1RCMmRmM2paR3c > > > (48KB). > > > > > > I hit situation with malformed event log on my Dell laptop - after TPM > > > firmware got updated from 1.2 to 2.0, chip & everything is reported as > > > TPM2, > > > except that log stays in TPM1.2 format. > > > > Great thank you. I think I'll merge this already to my master branch > > (not yet the whole series). Thanks a lot for spotting and fixing this > > regression. > > > > /Jarkko > > http://git.infradead.org/users/jjs/linux-tpmdd.git/commit/21229f46ce976bb8652d1da55f7823f4818b06d7 > > Please consider following in the future: > > - Short summary was misleading. It should fix loud and clear as > it fixes a real regression. It should not be called an improvement. > - Add the fixes line. > - I would recommend to submit fixes separately from rest of the series > so that they get more quickly noticed. > > This will make both your and my life easier... > > /Jarkko
And please run checkpatch: WARNING: line over 80 characters #61: FILE: drivers/char/tpm/tpm2_eventlog.c:69: + marker += efispecid->digest_sizes[j].digest_size; /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
