On Fri, 2017-06-16 at 10:25 -0700, Josh Zimmerman wrote:
> If a TPM2 loses power without a TPM2_Shutdown command being issued (a
> "disorderly reboot"), it may lose some state that has yet to be
> persisted to NVRam, and will increment the DA counter. After the DA
> counter gets sufficiently large, the TPM will lock the user out.
> 
> NOTE: This only changes behavior on TPM2 devices. Since TPM1 uses
sysfs,
> and sysfs relies on implicit locking on chip->ops, it is not safe to
> allow this code to run in TPM1, or to add sysfs support to TPM2,
until
> that locking is made explicit.
> 
> Signed-off-by: Josh Zimmerman <[email protected]>
> Cc: [email protected]
> 
> ----
> v2:
>   - Properly split changes between this and another commit
>   - Use proper locking primitive.
>   - Fix commenting style
> v3:
>   - Re-fix commenting style
> v4:
>   - Update description and tags (Reviewed-by, Cc).
> v5:
>   - Update documentation.
> v6:
>   - Call device and/or bus shutdown from tpm_shutdown.

The change log should be after the dashes *below* right before diff
stat. Since this is 1/2 I should be abe to assume that I could apply on
this and not apply 2/2.

Why this patch set does not have a cover letter?

Anyway, I applied these to my master and if they don't break anything
I'm including them to my 4.13 pull request. I left the commit messages
to the form that they turn out if I just git am -3 the mbox files.

Next time, do a git am sanity check if you have changelogs in your
patches.

/Jarkko

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
tpmdd-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel

Reply via email to