> On Thu, Aug 24, 2017 at 10:35:43AM +0200, Alexander Steffen wrote: > > When trying to send invalid commands (with mismatching commandSize > > values) to the TPM we discovered some cases in which data is sent to > > the TPM that should not be sent there. Similar problems were fixed > > years ago, but this one slipped through it seems. > > > > Alexander Steffen (2): > > tpm-dev-common: Reject too short writes > > tpm-interface: Fix checks of buffer size > > > > drivers/char/tpm/tpm-dev-common.c | 2 +- > > drivers/char/tpm/tpm-interface.c | 16 ++++++++-------- > > drivers/char/tpm/tpm.h | 3 ++- > > 3 files changed, 11 insertions(+), 10 deletions(-) > > > > -- > > 2.7.4 > > > > Have you checked that these do no break /dev/tpmrm0? > > I have some cheap unit tests here to smoke it: > > https://github.com/jsakkine-intel/tpm2-scripts > > /Jarkko
I've now included your tests in my automation, so that they will run for all my future changes. Is it sufficient to use tpm2_smoke.py or should I also run keyctl-smoke.sh? Not having used keyctl before, I'm not sure whether it has any dependencies/side effects. There was one thing I needed to fix to make the tests run with my TPMs and I've sent you a pull request via GitHub for it. Alexander ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
