This is a bug in Genshi, and I don't want to start talking about workarounds until it is clear there is no way to fix it directly.
This change was made in core because the hack to do themes from a plugin is incredibly brittle and this was relatively simple and doesn't actually change how things work other than internally. I have no objections to the CSS re-organization proposed on the ThemePlugins page, I just didn't want to get in to that. Otherwise its actually very similar to that proposal. --Noah On Mar 25, 2008, at 10:58 AM, Christian Boos wrote: > > Hi Noah & list, > > I've been a bit surprised by the recent addition of theming support in > http://trac.edgewall.org/changeset/6696. > > In your own words, theme support should probably have waited after the > 0.11 release (http://trac.edgewall.org/ticket/6185#comment:5), and > besides I think that the relative merits of your approach vs. the > other > proposed one > (http://trac.edgewall.org/wiki/TracDev/Proposals/ThemePlugins) could > at > least have been discussed on the list. > > Now, this wouldn't have been that important if this hadn't seriously > aggravated the main problem at hand, namely Trac's high memory usage. > Indeed, the working memory needed for building the rendered stream > *nearly doubled* with that change, as documented in #G190 > (http://genshi.edgewall.org/ticket/190#comment:23). > > I've also tested with the reports and here as well r6696 makes the > peak > memory usage quite higher, e.g. > > /report/1 now peaks at 65MB instead of 46MB. > /report/11 now peaks at 264MB instead of "only" 165MB. > > IMO this is really a too big price to pay for a feature that not > everybody will use (please note that the numbers given above > correspond > to a default installation of Trac, without any plugin or theme). And > I've not even spoken of timings here, but that has degraded as well. > > I also wonder if in general it wouldn't be possible to use a different > approach which would avoid to use <py:match> altogether, like having a > <xi:include href="layout_head.html"> in the <head> and similarly a > layout_body_top.html and layout_body_bottom.html included in the > <body> > for memory sensitive templates, like the report, query, changeset and > timeline. > > But at the very least, first let's not make things *worse* than they > already were. > > -- Christian > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
