Reviewers: ,
http://codereview.appspot.com/186050/diff/1/3 File trac/loader.py (right): http://codereview.appspot.com/186050/diff/1/3#newcode228 trac/loader.py:228: """ I would rephrase last part: "...the index of first reference to the plugin in traceback frames" http://codereview.appspot.com/186050/diff/1/3#newcode230 trac/loader.py:230: if f['filename'].startswith('build/')] Is there any example of traceback for reference? Or a unit test? I couldn't find any eggs with build/ path inside in my windows installation. http://codereview.appspot.com/186050/diff/1/3#newcode242 trac/loader.py:242: return The traceback sample won't hurt here. Can traceback filename extension be .pyc or .pyo? Can plugin filename be __init__.py? This code doesn't seem to include these cases. http://codereview.appspot.com/186050/diff/1/3#newcode245 trac/loader.py:245: base, ext = os.path.splitext(plugin['path']) plugin['path'] is Distribution.location (any other values?) - the path from where the plugin can be imported. Why split it into base, ext instead of more obvious .endswith('.egg') check below? http://codereview.appspot.com/186050/diff/1/3#newcode250 trac/loader.py:250: if f['filename'].startswith(base): Is base an absolute path or relative? Is it normalized? This check doesn't look reliable. Description: Can somebody answer my comments in rietvled? Thanks. http://trac.edgewall.org/ticket/5516 Please review this at http://codereview.appspot.com/186050 Affected files: M trac/htdocs/css/trac.css M trac/loader.py M trac/templates/about.html M trac/templates/error.html M trac/util/__init__.py M trac/web/main.py
-- You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en.
