'Twas brillig, and Remy Blank at 30/01/10 13:46 did gyre and gimble: > osimons wrote: >> That just strikes me as a bit... unexpected... Like all listeners in >> Trac, I assume these methods will fire whenever sync() picks up a new >> changeset or resyncs and old one, and not be something that needs >> repository hooks and command-line calls? > > There are several reasons why this is not the case: > > - Performance: with multiple repositories, we cannot afford anymore to > try and sync them all for every request. This is highly inefficient: > syncing once per request, when all that is needed is once per commit.
Massive nod there. I wrote a patch from trac-admin resync to accept a revision of "--latest" as a special case so that I could disable the "sync on every request" logic. With commit hooks etc. it should be trivial to set this up. That said, I think it should be an option - e.g. you should have to set "autosync = no" in the .ini file and then you become responsible for the running the repo sync. I agree also with your other points (esp. regarding full resync) but the above is something that has really hit me before. Out of curiosity, at what version did the autosync become disabled (or is this not yet released)? Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mandriva Linux Contributor [http://www.mandriva.com/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en.
