Hi! On Sun, Aug 8, 2010 at 1:24 PM, Remy Blank <[email protected]> wrote: > We have been avoiding conditional rendering based on the browser type up > to now, and preferring to generate output that works on all browsers. > How do browsers that don't support HTML5 react if they have to parse > HTML5? (Or that particular subset of HTML5 that you need for > multi-attachment processing).
There will be no problems with old browsers. To attach multiple files you just add a new attribute to input file fields. So old browsers will ignore it. Drag&drop is JavaScript event so if there is no support there will be no event. The only "problem" is that pages with that attribute (so all pages with attachment form) will not be XHTML valid anymore. As far as I can tell Trac is XHTML valid everywhere. This is why I am suggesting changing the doctype. If you are not concerned with failing XHTML validation tests on that attribute the we do not need to complicate with this. The workaround around is to set this attribute with JavaScript, so page is still XHTML valid. ;-) > I would prefer keeping multi-attachment and attachment preprocessing > separate, at least for now. This should make it easier to review. Of course this are two separate things to work on. They are also solving two different things - how to attach multiple things faster and how to process it automatically on the server side. But after some thought things are connected. If in preprocessing we allow that multiple new attachments are created (for example extracting an archive) then this preprocessing should know how to preprocess multiple attachments to begin with. But yes, first we do multi-attach support then we see how to add to that also preprocessing. > - Fork our repository on BitBucket or Github > - Implement only the UI part of multi-attachment, without the > associated processing. If switching to HTML5 rendering is necessary, > implement that, but unconditionally (i.e. for all browsers). If using > jQuery and keeping XHTML is possible, this would be preferred. UI will not be much. Only user will be able to select multiple files in a dialog box. The question is more how we handle description and replace checkbox. I will try to think about something. For now attach file page is quite empty so some new fields (for every file) are probably possible. > The post-processing should be a separate proposal, and could best be > started by creating a page below TracDev/Proposals, showing one or more > use cases, and describing the new / changed interface(s). OK. Will do that later. > Again, this is a perfectly valid feeling, given our track record. I > cannot make a promise, but I'll do my best to review your work and give > you feedback. Thanks! This is all that I hope for and it is enough for me. Mitar -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en.
