Hello Simon,

And now for somewhat completely different ;-)

On 10/1/2010 11:09 PM, osimons wrote:
On Sep 30, 2:15 pm, Christian Boos<[email protected]>  wrote:
...
Comments welcome, in particular concerning how much we should
deprecate the "old" ways, in particular if we should remove the good
old `env.get_db_cnx()` completely, and when.
So I'll keep the status quo for now, but we may want to remove it at
some point later (or at least, log a warning whenever it get used).

I think the API looks very good, and makes sense when aiming for
Python 2.5 as minimum. Great work!

Thanks! Remy was also fine with the changes, so I'll commit them tomorrow (tons of changes, but in the end... a bit less code (2927 insertions, 3130 deletions) and this with more documentation strings ;-)

As for env.get_db_cnx() there is a LOT of code out there that use it.
Removing it will be quite troublesome to say the least...


As briefly discussed on #trac, I think we can continue to support it provided the people using that older API would also call a "env.is_in_transaction()" method that would inform them whether they have to commit() their changes by themselves or that they shouldn't as they're part of a larger transaction.

-- Christian



--
You received this message because you are subscribed to the Google Groups "Trac 
Development" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/trac-dev?hl=en.

Reply via email to