Hi Remy and Simon, and thanks for your insightful feedback! Instead of quoting your answers I will try to write a conclusion myself. First, I will of course do the proposed small changes from Remy (the ones you said were "not so important"). Now on to the harder topics, which have become two:
1. Event rendering, and 2. Timeline flags Topic 1. Event rendering: I guess I have to try to re-write all of the event-rendering code then. This will take some time, and will need some iterations, with your help I hope :) Simon vented his ideas regarding this in his reply. #6492 contains lots of fruits for thoughts. I therefore think this should be coordinated by a separate ticket, and the workflow would then be to first re-factor the event rendering only, based on trunk and not on the current patches in #6492. Then, when that is accepted and applied to trunk, the patches in #6492 are adapted, which should reduce the amount of changes on trunk from #6492 (at that stage). I will of course work on the patches for #6492 in parallel with this. Topic 2. Timeline flags: This was raised by Simon in his answer (oh well, let's quote that). > New 'flags' being added to TimelineModule > that do things such as "Highlight my tickets", has no place in Timeline code. > The timeline code already have options, settings and code that deal with > Trac-specific modules in ways that external plugins cannot. We should move > away from this, and if anything provide extension points for plugins to add > features or do post-processing on results before displaying them. Timeline > should be completely module-agnostic. First I was a bit startled reading this, but I then almost immediately realized that you are absolutely correct. Of course. This should be fixed as well. I think the highlighting option flags are necessary, however not the way they are implemented in the patches in #6492. Perhaps the options should be exclusive, i.e. it is only possible to highlight events on the Timeline from one aspect only, such as "my owned tickets", "my ticket changes", "my commits", "my wiki edits" etc. The highlighting options could then be provided by the resource owner, in a similar manner as the current filters, but presented as a radio button group. If you agree with this, the next step would be to create a ticket on Trac coordinating the refactoring of the Timeline module. (However, due to work load and not being a pythonic-pro-coder, I will probably not be able to complete this until jan-feb next year...) Best regards, Mikael PS. I guess you could say I didn't know what I got myself into when I started to code on #6492... I had only set up a goal to extend the core of Trac with some nice features, but I now understand that the Timeline module are not ready to be extended without some considerations first. But hey, that's a fun challenge :) DS. -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en.
