We're using the CommitTicketUpdater extension with a Mercurial repository, and I've noticed a bit of trouble closing tickets from the commit message.
It seems that CommitTicketUpdater uses the changeset author to lookup permissions for that user and verify that they are allowed to close tickets. I am in some disagreement here, since I think if a changeset closing a ticket makes it into a repository the ticket should be closed. This is particularly true for the DVCS case, where a changeset may be authored by a third party and pushed to the repo by a trusted committer. At the very least I believe the permission check should be optional. The other half of this issue is that TracMercurial is passing through the Hg user verbatim. The convention if for these users to take the form "Bob Smith <[email protected]>" while Bob's trac user is more likely to be "[email protected]". I propose that the author provided to the Changeset object be parsed down to just an email address if possible. James -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en.
