On Friday, November 22, 2013 9:48:37 AM UTC-8, Olemis Lang wrote: > > > On Thu, Nov 21, 2013 at 5:42 PM, RjOllos <[email protected] > <javascript:>>wrote: > >> >> >> On Thursday, November 21, 2013 5:53:21 AM UTC-8, Chris Nelson wrote: >>> >>> [...] > >> > >>> > My personal feeling is to discourage such an insane filename (report >>> it >>> > in a warning?) in the first place. Neither have I encountered such a >>> > wired filename before nor can I see a valid use case and consequently >>> > the need to support it. Is this unrealistic thinking? >>> >>> I agree. Spaces in file names is one thing but vertical white space? >>> That's insane. >>> >> >> I'm in agreement on the insane aspect of it, but it seems to work just >> fine to create a file with a linefeed character on TracStandalone: >> >> $ echo "Some text" > "myfile >> " >> >> The linefeed character is encoded as %0A: myfile%0A >> > > IMO let's better filter such file upload requests and return an HTTP 400 > Bad Request back to the caller with an informative message . >
What is your reasoning for throwing an error on the request? It seems that Trac handles the case without any issue and nothing breaks when uploading a file with a newline in the filename; it's such an odd scenario that I can't see the need to add any special handling for it in the codebase. I might feel differently if Trac couldn't handle the file. -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/trac-dev. For more options, visit https://groups.google.com/groups/opt_out.
