On Tuesday, August 23, 2016 at 6:06:47 PM UTC-7, Tim Graham wrote: > > Yes, it's some effort to keep the state of tickets and pull requests in > sync. We have a "Has patch" field on our tickets as well as flags like > "Patch needs improvement", "Needs documentation", "Needs tests". The ticket > review queue is the tickets that have "Has patch" checked without any of > the "Needs improvement" flags. After I review a pull request, I'll check > the "Needs improvement" flag and ask the contributor to uncheck it after > they update the PR. > > Look at https://code.djangoproject.com/ticket/27089 and search for "Pull > requests:" The code that generates that is > https://github.com/django/code.djangoproject.com/blob/669bc946bdd378fa6e086acb3e8af80bfd319eb9/trac-env/htdocs/tickethacks.js#L99-L208 >
That looks like something we could use in Trac if we were setup to merge Pull Requests on GitHub. I'll keep that in mind if we get the 2-way repository synchronization setup that would allow us to merge pull requests from GitHub. It looks like that pull requests query through the GitHub API must run every time a Trac ticket page is loaded, but the page load time is still very good. Impressive! - Ryan -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/trac-dev. For more options, visit https://groups.google.com/d/optout.
