On Sun, 25 Nov 2012 16:07:56 +0200, Ezio Melotti <ezio.melo...@gmail.com> wrote:
> On Sun, Nov 25, 2012 at 3:30 PM, anatoly techtonik <techto...@gmail.com>wrote:
> 
> > On Sun, Nov 25, 2012 at 1:56 AM, Ezio Melotti <ezio.melo...@gmail.com>wrote:
> >
> >> On Sun, Nov 25, 2012 at 12:24 AM, anatoly techtonik 
> >> <techto...@gmail.com>wrote:
> >>
> >>> On Sat, Nov 24, 2012 at 7:04 AM, Ezio Melotti <ezio.melo...@gmail.com>
> >>>  wrote:
> >>> Nice. Is it possible to add this lookup to the post commit hook script
> >>> to report about amount of patches available for files that had
> >>> been committed? It is much easier to review code that's already in your
> >>> mind.
> >>>
> >>
> >> I'm not sure I understand what you are asking here.  Are you suggesting
> >> to add a mercurial hook that, once you commit/push something, suggests
> >> other issues with patches that affect the same file(s)?
> >>
> >
> > Right. After you've pushed something, a short message from server on the
> > screen:
> >
> >   Thanks for your contribution to the module XXX, YYY, ... .
> >
> >   Please note that files that you've touched have X open patches
> >   on the bug tracker. It might be the best time to review some now.
> >   ...
> >
> > This serves two purpose:
> > 1. Encourages people to review patches or do something else about them
> > (split issues) to avoid languishing
> > 2. Complete stdlib.json mapping (yes, I am lazy, and it will be more fun
> > for people to fill their missing modules themselves)
> >
> 
> It might turns out to be annoying for developers though.  If they are the
> maintainers of some specific module they probably know the other issues
> already, if they aren't they might not care.  This will also make pushing
> slower and might introduce problems.

If someone writes such a commit hook, it could be provided for developers
to install locally.  That way only those who find it useful will see
the output.

--David
_______________________________________________
Tracker-discuss mailing list
Tracker-discuss@python.org
http://mail.python.org/mailman/listinfo/tracker-discuss

Reply via email to