New submission from Maciej Szulik:
@anish.shah
> pullrequest_number = match.group('id')
Use shorter naming, like mentioned in #586, iow pr_id/pr_no.
> github_pullrequest_url_id = cl.lookup(pullrequest_number)
There are two problems with this approach:
1. You lookup from the list of all patches, not necessarily connected with that
particular issue.
Iow. I have issue1 with PR1 and issue2 w/o PR number and when I enter PR1 in
issue2 I'm getting a
link to PR1 from issue1, which should not happen.
Either you want to restrict that to this particular issue, you'd need to
check issues's prs specifically
to fix it. Or...
2. Don't do lookups at all, but always assume the format we've settled on to be
something you should turn
into a link. Additionally, you could think of adding such link to the list
of links.
Personally, I'm more towards the latter.
Thanks!
_______________________________________________________
PSF Meta Tracker <[email protected]>
<http://psf.upfronthosting.co.za/roundup/meta/issue587>
_______________________________________________________
_______________________________________________
Tracker-discuss mailing list
[email protected]
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/
