Maciej Szulik added the comment:
> endpoint = 'https://api.github.com/repos/AnishShah/cpython/pulls'
That endpoint doesn't look right, does it ;) ?
> "body": "fixes issue {}".format(issue_id),
...
> commit_msg = 'Fixes issue {} : {}'.format(issue_id, title)
It would be nice to use 'Fixes issue bpo<number>' in both cases, to be
consistent
and so that patch from #589 links the issue properly, even if you're doing
this manually in the next lines.
> issue_pr = db.issue.get(issue_id, 'github_pullrequest_urls')
This needs update to reflect current state of #586, additionally you should
update the title to have that dependency in the title, like the others.
> # err takes stdout
> # if err:
> # raise Exception(err)
We do need proper error handling, still.
> filename = db.file.get(file_id, 'name')
> content = db.file.get(file_id, 'content')
> fp = open(os.path.join(path, filename), 'wb')
> fp.write(content)
> fp.close()
Create a ContextManager (you need to write one manually) using tempfile.mkdtemp
to create a temporary directory
and clean it afterwards.
> # git_workflow(newvalues)
If not needed - remove, if needed - uncomment.
Would it be hard to add test cases covering that flow?
_______________________________________________________
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue600>
_______________________________________________________
_______________________________________________
Tracker-discuss mailing list
Tracker-discuss@python.org
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/
