Edward Duffy wrote:
> Ok.  Here's a patch to tracker-thumbnailer to
>  1) Remove the old style /path/to/mime/type_thumbnailer
>  2) Support the Thundar style .desktop file
>  3) If ^^^^^ fails, try gconf's
> /desktop/gnome/thumbnailers/[EMAIL PROTECTED]/command key
>  4) Add .desktop thumbnailers for OO.o, Dia, pdf, and ps (all depend
> on imagemagick)
> 
> The thumbnails that get generated are not immediately found by
> nautilus (killall nautilus fixes that), however Thundar appears to be
> tracking ~/.thumbnails, so the thumbnails generated by tracker show
> up.
> 

thanks - mostly ok but...

a few snags:

1) do a svn update - bits of quite old code are in your patch

2) I dont like the fact that we are parsing desktop files and checking 
gconf every time the thumbnailer is called.

We need to be smarter than that - perhaps stick a GHashTable for 
mime->thumbnailer in the tracker struct (tracker-utils.h) and load all 
the thumbs/mime at trackerd startup rather than each time we index a 
file. That way we can quickly get at the thumbnailer for a mime while 
indexing.

3) tracker-thumbnailer should set an alarm for the thumbnailer it spawns 
(just in case of reap failure).

if it plays out well we could adopt the same desktop format for text 
filters (and metadata extractors too once I have altered the code for 
that to support external ones like strigii's xmlindexer and third party 
ones as well)

-- 
Mr Jamie McCracken
http://jamiemcc.livejournal.com/

_______________________________________________
tracker-list mailing list
tracker-list@gnome.org
http://mail.gnome.org/mailman/listinfo/tracker-list

Reply via email to