On Mon, 2007-12-03 at 17:07 +0800, Rick Ju wrote: > Hi, Jamie, > > Please review the patch. It is not fully tested yet and not compatible > with Solaris since more work may be needed.
what else is needed? > > a. Is get_files()(tracker-utils.c) appropriate place to check remote > dir? If user explicitly add a remote mounted directoy in watch/crawl > list, and the SkipRemoteMount == True, the directory should still be > indexed. we already have existing code which is broken there All you need to do is update functions tracker_file_is_in_root_dir, tracker_add_root_directories and tracker_add_root_dir in tracker-utils.c (a root directory is a mount point) > > b. Is another SkipRemoteMounts needed? or just use current > SkipMountPoints? I am not sure what exactly SkipMountPoints means. no they are the same - so only one is needed jamie _______________________________________________ tracker-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/tracker-list
