On Mon, 2008-01-21 at 15:15 +0100, Mathieu Dimanche wrote: > Michael Biebl a écrit : > > 2008/1/21, Halton Huo <[EMAIL PROTECTED]>: > > > >> On Fri, 2008-01-18 at 10:48 +0800, Halton Huo wrote: > >> > >>>> [2]. tracker-preferences will send out the key changes D-BUS message > >>>> when user click the widget, that will cause trackerd get the change > >>>> > >>> and > >>> > >>>> take effect directly. I'd like to change t-p to send out the changes > >>>> only after use click "Close" button. What do you think? > >>>> > >> Patch for this is ready. Please review it also. > >> > >> The basic idea is to have a GSList to store all the changes instead of > >> sending out D-Bus messages directly. After user click "Close" button, go > >> > > > > The problem is, that this doesn't follow GNOME's instant-apply idea. > > > I'm not really sure the preferences dialog follows the instant-apply scheme. > > As seen in the Gnome HIG v2.0 [1], my guess is this particuliar dialog > should be an "explicit apply window" : > [...] > If most of the controls in your window are not suitable for instant > apply, consider making the whole window "explicit apply". An explicit > apply window has these three buttons in its button box, plus an optional > Help button: Apply/Cancel/OK > [...] > > > Mathieu > > [1] http://developer.gnome.org/projects/gup/hig/2.0/windows-utility.html > > > > It would also be counter intuitive, to apply the settings with > > "Close". "Ok" would be much better imho. > > Atm it's not very consistent unfortunately. Some settings are applied > > instantly, some only on close. > >
the settings by the nature mix both types however instant apply does not make sense for stuff that requires a reindex or restart as you might wanna change several settings before triggering the restart/reindex I guess it needs to be consistent so explicit apply with an apply button should be done for the whole window Halton - feel free to tidy it up this way jamie _______________________________________________ tracker-list mailing list tracker-list@gnome.org http://mail.gnome.org/mailman/listinfo/tracker-list
