2008/12/22 Martyn Russell <mar...@imendio.com>: > On 19/12/08 21:52, Michael Biebl wrote: >> >> Hi folks, >> >> attached is a patch, that cleans up the built system a bit. >> 1.) It removes BUILT_SOURCES from DIST_FILES >> 2.) Removes all the symlinking from configure.ac and >> src/tracker-indexer/Makefile.am >> instead >> 3.) Add $(top_buildir)/src/tracker-indexer so include path of >> tests/tracker-indexer >> and include the files via $(top_srcdir)/src/tracker-indexer/foo.c >> 4.) Add tracker-removable-device.h to tracker_indexer_SOURCES >> >> This simplifies the build system quite a bit and better separates the >> tests from the source code. > > Hi, > > Great patch! I have a few comments: > > -I$(top_srcdir)/src \ > -I$(top_srcdir)/tests/common \ > + -I$(top_builddir)/src/tracker-indexer > > Hmm, I am guessing $(top_builddir) is necessary when doing make distcheck > where the build dir is not the same as the original source dir? If so, > shouldn't we be using this all over the place and not using $(top_srcdir)? > like in the other 2 lines above?
Depends on what you need: If you want to include generated header files (like tracker-indexer-glue.h) then $(top_builddir) is correct, if you want to include static header files (like tracker-common.h), then $(top_srcdir) is correct. Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? _______________________________________________ tracker-list mailing list tracker-list@gnome.org http://mail.gnome.org/mailman/listinfo/tracker-list
