On Thu, 2009-04-02 at 10:26 +0100, Richard Hughes wrote: > The attached patch splits TrackerHal into TrackerStorage and > TrackerPower to better split the functionalities for future work. This > is needed for future patches to add DeviceKit support. I've also created > the files tracker-storage-hal and tracker-power-hal so that the power > and storage code can be compiled into a HAL or DeviceKit backends in the > future.
Would it be possible to also perform the merge to vstore? Right after the commit in trunk is most easy, the 'master' in that git was done using git-svn I think (best person to ask is Jürg Billeter who maintains the vstore branch. http://git.codethink.co.uk/?p=tracker;a=shortlog;h=vstore We will otherwise have to do this and then we might get various things wrong. We'll very soon merge vstore to trunk so if we'd merge things wrongly, then your excellent work would then get damaged. I'll let Martyn Russel comment on the patch itself, he's atm maintaining the HAL parts in trunk. ps. I added Martyn and Jürg in CC. > The diffstat looks huge, but it's really just splitting the GObject and > reorganising the filenames, there are no real logic changes. I've done a > quick test of trackerd, but it probably needs someone familiar with the > self tests to check this before it's committed. > > [hugh...@hughsie-work tracker]$ cat tracker-split-hal.patch | diffstat > libtracker-common/Makefile.am | 6 > libtracker-common/tracker-albumart.c | 6 > libtracker-common/tracker-common.h | 3 > libtracker-common/tracker-hal.c | 1299 > -------------------------------- > libtracker-common/tracker-hal.h | 78 - > libtracker-common/tracker-power-hal.c | 588 ++++++++++++++ > libtracker-common/tracker-power.h | 65 + > libtracker-common/tracker-storage-hal.c | 953 +++++++++++++++++++++++ > libtracker-common/tracker-storage.h | 74 + > tracker-indexer/tracker-indexer.c | 44 - > trackerd/tracker-main.c | 62 - > trackerd/tracker-processor.c | 36 > trackerd/tracker-processor.h | 4 > trackerd/tracker-status.c | 10 > trackerd/tracker-status.h | 4 > 15 files changed, 1773 insertions(+), 1459 deletions(-) > > Feedback please. I'll submit further patches when this patch is > accepted. I have commit on gnome svn if this helps. Thanks. -- Philip Van Hoof, freelance software developer home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org http://pvanhoof.be/blog http://codeminded.be _______________________________________________ tracker-list mailing list tracker-list@gnome.org http://mail.gnome.org/mailman/listinfo/tracker-list
