Philip Van Hoof wrote:
On Mon, 2009-04-13 at 18:08 +0200, Carlos Garnacho wrote:
- in on_queue_timeout(), why is there a need to check whether the source
was already destroyed? are we multithreaded there?
Programming practice. I try to always do this as it's the right way to
do a callback if your GSource can be g_source_remove()-ed.
This is bad practise unless you are threaded which we are not. The
source function is never called if the source has been removed already
so checking if it exists in the callback is folly ;)
Please review
I will be shortly.
--
Regards,
Martyn
_______________________________________________
tracker-list mailing list
tracker-list@gnome.org
http://mail.gnome.org/mailman/listinfo/tracker-list
